From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 5/9] metadata: data_storage: Add two array functions
Date: Thu, 19 Dec 2024 11:45:58 +0100 [thread overview]
Message-ID: <Z2P5ZkeorHaHC0nh@yuki.lan> (raw)
In-Reply-To: <20241218192136.GE80422@pevik>
Hi!
> > - data_node_array_last() returns last element in an array or NULL if empty
>
> > - data_node_array_last_rem() removes and frees last element from an array
> Would you mind to add the above as /** */ doc to the functions before merging?
> (no need to repost).
The whole file needs documentation, I will add that to my ever growing
TODO.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-12-19 10:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 19:00 [LTP] [PATCH 0/9] Metadata parser fixes Cyril Hrubis
2024-12-18 19:00 ` [LTP] [PATCH 1/9] metadata: metaparse: Parse operators *, +, and | properly Cyril Hrubis
2024-12-18 19:08 ` Petr Vorel
2024-12-19 10:45 ` Cyril Hrubis
2025-01-09 13:43 ` Cyril Hrubis
2024-12-18 19:00 ` [LTP] [PATCH 2/9] metadata: metaparse: Implement recursive include Cyril Hrubis
2024-12-18 19:10 ` Petr Vorel
2024-12-18 19:00 ` [LTP] [PATCH 3/9] metadata: metaparse: Apply macros in arrays Cyril Hrubis
2024-12-18 19:13 ` Petr Vorel
2024-12-18 19:00 ` [LTP] [PATCH 4/9] metadata: data_storage: Add JSON null type Cyril Hrubis
2024-12-18 19:15 ` Petr Vorel
2024-12-18 19:00 ` [LTP] [PATCH 5/9] metadata: data_storage: Add two array functions Cyril Hrubis
2024-12-18 19:21 ` Petr Vorel
2024-12-19 10:45 ` Cyril Hrubis [this message]
2024-12-18 19:00 ` [LTP] [PATCH 6/9] metadata: metaparse: Better array parsing Cyril Hrubis
2024-12-19 14:01 ` Petr Vorel
2024-12-18 19:00 ` [LTP] [PATCH 7/9] metadata: metaparse: Ignore ', ' in array inside parenthesis Cyril Hrubis
2024-12-19 14:13 ` Petr Vorel
2024-12-18 19:00 ` [LTP] [PATCH 8/9] metadata: metaparse: Add a few pre-defined macros Cyril Hrubis
2024-12-19 14:16 ` Petr Vorel
2024-12-19 14:25 ` Cyril Hrubis
2024-12-27 7:32 ` Petr Vorel
2024-12-18 19:00 ` [LTP] [PATCH 9/9] metadata: parse.sh: Add -Itestcases/kernel/include Cyril Hrubis
2024-12-19 14:17 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2P5ZkeorHaHC0nh@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.