From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, philmd@linaro.org, qemu-rust@nongnu.org
Subject: Re: [PATCH 3/7] rust: pl011: always use reset() method on registers
Date: Thu, 19 Dec 2024 14:55:20 +0800 [thread overview]
Message-ID: <Z2PDWJo6G0DQ5uzl@intel.com> (raw)
In-Reply-To: <20241212172209.533779-4-pbonzini@redhat.com>
On Thu, Dec 12, 2024 at 06:22:00PM +0100, Paolo Bonzini wrote:
> Date: Thu, 12 Dec 2024 18:22:00 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 3/7] rust: pl011: always use reset() method on registers
> X-Mailer: git-send-email 2.47.1
>
> For CR, the ugly-ish "0.into()" idiom is already hidden within the
> Default trait. Do not repeat it.
>
> For FR, standardize on reset() being equivalent to "*self = Self::default()"
> and let reset_fifo toggle only the bits that are related to FIFOs. This
> commit also reproduces C commit 02b1f7f6192 ("hw/char/pl011: Split RX/TX
> path of pl011_reset_fifo()", 2024-09-13).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/hw/char/pl011/src/device.rs | 23 ++++++++++++++++-------
> rust/hw/char/pl011/src/lib.rs | 13 +++++--------
> 2 files changed, 21 insertions(+), 15 deletions(-)
>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2024-12-19 6:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 17:21 [PATCH 0/7] rust: pl011: bug fixes Paolo Bonzini
2024-12-12 17:21 ` [PATCH 1/7] rust: pl011: fix declaration of LineControl bits Paolo Bonzini
2024-12-18 13:23 ` Philippe Mathieu-Daudé
2024-12-19 3:42 ` Zhao Liu
2024-12-12 17:21 ` [PATCH 2/7] rust: pl011: match break logic of C version Paolo Bonzini
2024-12-18 13:18 ` Philippe Mathieu-Daudé
2024-12-19 4:38 ` Zhao Liu
2024-12-19 6:31 ` Paolo Bonzini
2024-12-12 17:22 ` [PATCH 3/7] rust: pl011: always use reset() method on registers Paolo Bonzini
2024-12-18 13:28 ` Philippe Mathieu-Daudé
2024-12-19 6:55 ` Zhao Liu [this message]
2024-12-12 17:22 ` [PATCH 4/7] rust: pl011: fix break errors and definition of Data struct Paolo Bonzini
2024-12-18 14:49 ` Philippe Mathieu-Daudé
2024-12-19 7:17 ` Zhao Liu
2024-12-12 17:22 ` [PATCH 5/7] rust: pl011: extend registers to 32 bits Paolo Bonzini
2024-12-18 13:43 ` Philippe Mathieu-Daudé
2024-12-19 7:30 ` Zhao Liu
2024-12-12 17:22 ` [PATCH 6/7] rust: pl011: fix migration stream Paolo Bonzini
2024-12-18 14:50 ` Philippe Mathieu-Daudé
2024-12-19 7:52 ` Zhao Liu
2024-12-12 17:22 ` [PATCH 7/7] rust: pl011: simplify handling of the FIFO enabled bit in LCR Paolo Bonzini
2024-12-18 13:20 ` Philippe Mathieu-Daudé
2024-12-19 7:55 ` Zhao Liu
2024-12-18 11:17 ` [PATCH 0/7] rust: pl011: bug fixes Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2PDWJo6G0DQ5uzl@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.