All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: don't include '<linux/rwlock_types.h>' directly
Date: Thu, 19 Dec 2024 12:27:39 +0100	[thread overview]
Message-ID: <Z2QDK9uFrXUIhJn2@shikoro> (raw)
In-Reply-To: <0199c644-dfd7-43ce-b02a-459461299fb7@gmx.com>

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Hi,

> > -#include <linux/rwlock_types.h>
> > +#include <linux/spinlock_types.h>
> 
> I think we can just remove the *_type.h include header completely.

I agree, spinlock.h is enough.

> For non-RT build, spinlock.h will include linux/rwlock.h, and
> spinlock_types.h unconditionally.

Yet, isn't it always included unconditionally?

spinlock.h -> spinlock_types.h -> rwlock_types.h

I don't see any conditionals there.

Thanks for the review and happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-12-19 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17  7:05 [PATCH] btrfs: don't include '<linux/rwlock_types.h>' directly Wolfram Sang
2024-12-17  7:14 ` Qu Wenruo
2024-12-19 11:27   ` Wolfram Sang [this message]
2024-12-23 19:18     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2QDK9uFrXUIhJn2@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.