From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: "Namhyung Kim" <namhyung@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>,
"Chen Ni" <nichen@iscas.ac.cn>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] Prefer evsel over evsel->core.idx
Date: Fri, 20 Dec 2024 16:45:11 -0300 [thread overview]
Message-ID: <Z2XJR5K-dQIJRuJO@x1> (raw)
In-Reply-To: <CAP-5=fXOdoyuXwTC2coFUAg_ruaYqj3KVe27YjcBtHCAFt_NeA@mail.gmail.com>
On Fri, Dec 20, 2024 at 10:57:58AM -0800, Ian Rogers wrote:
> On Fri, Dec 13, 2024 at 4:13 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > On Thu, Nov 14, 2024 at 03:07:10PM -0800, Ian Rogers wrote:
> > > James Clark's patches fixing evsel->core.idx [1] reminded me that we
> > > pass the int value around unnecessarily. Passing the evsel avoids
> > > issues if the evlist is reordered but paired with sanitizers we can
> > > also know when something is used when it shouldn't be. These patches
> > > do some initial work reducing the use of evsel->core.idx or reducing
> > > the API to pass evsels and not their interior index.
> > >
> > > [1] https://lore.kernel.org/lkml/20241114160450.295844-2-james.clark@linaro.org/
> > >
> > > Ian Rogers (3):
> > > perf stream: Use evsel rather than evsel->idx
> > > perf values: Use evsel rather than evsel->idx
> > > perf annotate: Prefer passing evsel to evsel->core.idx
>
> Ping.
>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
> Reviewed-by: James Clark <james.clark@linaro.org>
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2024-12-20 19:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 23:07 [PATCH v1 0/3] Prefer evsel over evsel->core.idx Ian Rogers
2024-11-14 23:07 ` [PATCH v1 1/3] perf stream: Use evsel rather than evsel->idx Ian Rogers
2024-11-14 23:07 ` [PATCH v1 2/3] perf values: " Ian Rogers
2024-11-14 23:07 ` [PATCH v1 3/3] perf annotate: Prefer passing evsel to evsel->core.idx Ian Rogers
2024-12-20 19:50 ` Arnaldo Carvalho de Melo
2024-11-18 10:18 ` [PATCH v1 0/3] Prefer evsel over evsel->core.idx James Clark
2024-12-14 0:13 ` Namhyung Kim
2024-12-20 18:57 ` Ian Rogers
2024-12-20 19:45 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2XJR5K-dQIJRuJO@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=namhyung@kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.