From: Sukrut Bellary <sbellary@baylibre.com>
To: Judith Mendez <jm@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@ti.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Bin Liu <b-liu@ti.com>
Subject: Re: [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART
Date: Sat, 21 Dec 2024 03:16:26 -0800 [thread overview]
Message-ID: <Z2ajiuumq0CeM/u7@dev-linux> (raw)
In-Reply-To: <20241220223523.2125278-1-jm@ti.com>
On Fri, Dec 20, 2024 at 04:35:23PM -0600, Judith Mendez wrote:
> According to the TRM [0] in 21.5.1.42 UART_SYSC Register,
> the autoidle bit should not be set for UART, so remove the
> appropriate SYSC_OMAP2_AUTOIDLE flag.
>
> [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> arch/arm/boot/dts/ti/omap/am437x-l4.dtsi | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> index 824b9415ebbe9..fd4634f8c6293 100644
> --- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> @@ -180,8 +180,7 @@ target-module@9000 { /* 0x44e09000, ap 16 04.0 */
> <0x9058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -698,8 +697,7 @@ target-module@22000 { /* 0x48022000, ap 8 0a.0 */
> <0x22058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -726,8 +724,7 @@ target-module@24000 { /* 0x48024000, ap 10 1c.0 */
> <0x24058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -1385,8 +1382,7 @@ target-module@a6000 { /* 0x481a6000, ap 40 16.0 */
> <0xa6058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -1413,8 +1409,7 @@ target-module@a8000 { /* 0x481a8000, ap 42 20.0 */
> <0xa8058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -1441,8 +1436,7 @@ target-module@aa000 { /* 0x481aa000, ap 44 12.0 */
> <0xaa058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> --
> 2.47.1
>
Looks good to me.
Reviewed-by: Sukrut Bellary <sbellary@baylibre.com>
next prev parent reply other threads:[~2024-12-21 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 22:35 [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART Judith Mendez
2024-12-21 11:16 ` Sukrut Bellary [this message]
2025-01-06 23:07 ` Kevin Hilman
2025-01-06 23:45 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2ajiuumq0CeM/u7@dev-linux \
--to=sbellary@baylibre.com \
--cc=b-liu@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=khilman@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.