From: Long Li <leo.lilong@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <djwong@kernel.org>, <cem@kernel.org>,
<linux-xfs@vger.kernel.org>, <david@fromorbit.com>,
<yi.zhang@huawei.com>, <houtao1@huawei.com>,
<yangerkun@huawei.com>, <lonuxli.64@gmail.com>
Subject: Re: [PATCH 1/2] xfs: remove redundant update for t_curr_res in xfs_log_ticket_regrant
Date: Mon, 23 Dec 2024 09:04:17 +0800 [thread overview]
Message-ID: <Z2i3EdBPFxlY5cHH@localhost.localdomain> (raw)
In-Reply-To: <Z2Z25oUtIqtV_wjO@infradead.org>
On Sat, Dec 21, 2024 at 12:05:58AM -0800, Christoph Hellwig wrote:
> On Sat, Dec 21, 2024 at 02:30:42PM +0800, Long Li wrote:
> > The current reservation of the log ticket has already been updated in
> > xfs_log_ticket_regrant(),
>
> Maybe say "a few lines above" as both calls are in
> xfs_log_ticket_regrant?
Thanks for your review , it's a good suggestion for me, I'll update it
in next version.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
>
next prev parent reply other threads:[~2024-12-23 1:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 6:30 [PATCH 0/2] xfs: two small cleanup Long Li
2024-12-21 6:30 ` [PATCH 1/2] xfs: remove redundant update for t_curr_res in xfs_log_ticket_regrant Long Li
2024-12-21 8:05 ` Christoph Hellwig
2024-12-23 1:04 ` Long Li [this message]
2024-12-21 6:30 ` [PATCH 2/2] xfs: remove bp->b_error check in xfs_attr3_root_inactive Long Li
2024-12-21 8:08 ` Christoph Hellwig
2024-12-23 1:08 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2i3EdBPFxlY5cHH@localhost.localdomain \
--to=leo.lilong@huawei.com \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lonuxli.64@gmail.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.