All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Eric Blake" <eblake@redhat.com>,
	"Stefan Fritsch" <sf@sfritsch.de>,
	qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-stable@nongnu.org, "John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH] dma-helpers: Fix iovec alignment
Date: Mon, 23 Dec 2024 12:42:48 -0500	[thread overview]
Message-ID: <Z2mhGN3XDaIXFibM@x1n> (raw)
In-Reply-To: <3fd9f735-6243-4081-878d-bb5b61f7dda7@tls.msk.ru>

On Sat, Dec 21, 2024 at 12:07:05AM +0300, Michael Tokarev wrote:
> 11.08.2024 20:47, Michael Tokarev пишет:
> > 12.04.2024 18:25, Eric Blake wrote:
> > > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote:
> > > > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a
> > > > dynamic field 'align' but introduced a bug. qemu_iovec_discard_back()
> > > > is now passed the wanted iov length instead of the actually required
> > > > amount that should be removed from the end of the iov.
> > > > 
> > > > The bug can likely only be hit in uncommon configurations, e.g. with
> > > > icount enabled or when reading from disk directly to device memory.
> > 
> > Hi!
> > 
> > Has this change (proposed for 9.0) been forgotten or is it not needed
> > anymore?
> 
> Ping #2?

Hello, Michael,

Looks like we didn't reach a consensus on merging it?  See:

https://lore.kernel.org/qemu-devel/CAFn=p-Y1sAXfzx6cWEgeYyMyG3yn1vEpDmV2K8qWtLx4otm4tw@mail.gmail.com/

Thanks,

-- 
Peter Xu



      reply	other threads:[~2024-12-23 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12  8:06 [PATCH] dma-helpers: Fix iovec alignment Stefan Fritsch
2024-04-12  9:51 ` Philippe Mathieu-Daudé
2024-04-12 15:25 ` Eric Blake
2024-04-16 11:36   ` Stefan Fritsch
2024-08-12 18:27     ` John Snow
2024-08-13 16:26       ` Stefan Fritsch
2024-08-11 17:47   ` Michael Tokarev
2024-12-20 21:07     ` Michael Tokarev
2024-12-23 17:42       ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2mhGN3XDaIXFibM@x1n \
    --to=peterx@redhat.com \
    --cc=david@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=sf@sfritsch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.