From: "J. Neuschäfer" <j.ne@posteo.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: j.ne@posteo.net, Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] gpio: 74x164: Add latch GPIO support
Date: Tue, 24 Dec 2024 07:26:21 +0000 [thread overview]
Message-ID: <Z2piHTP63SpaatHv@probook> (raw)
In-Reply-To: <CACRpkdYibsJvnKazKaqQjLYyL4Hx1K1MpFpM2UPCRbDN3Gxh-w@mail.gmail.com>
On Sun, Dec 22, 2024 at 09:58:39AM +0100, Linus Walleij wrote:
> On Fri, Dec 13, 2024 at 6:32 PM J. Neuschäfer via B4 Relay
> <devnull+j.ne.posteo.net@kernel.org> wrote:
>
> > From: "J. Neuschäfer" <j.ne@posteo.net>
> >
> > The Fairchild MM74HC595 and other compatible parts have a latch clock
> > input (also known as storage register clock input), which must be
> > clocked once in order to apply any value that was serially shifted in.
> >
> > This patch adds driver support for using a GPIO that connects to the
> > latch clock.
> >
> > Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
>
> This looks completely reasonable to me as far as 2/4 gets merged:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I think I prefer the other option, of documenting that the latch clock
pin pretty much behaves as a chip select.
Having a separately described latch clock would mean no CS for these
chips, and the SPI bindings and drivers don't expect devices without CS.
-- jn
prev parent reply other threads:[~2024-12-24 7:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 17:32 [PATCH 0/4] gpio: 74HC595 / 74x164 shift register improvements J. Neuschäfer
2024-12-13 17:32 ` J. Neuschäfer via B4 Relay
2024-12-13 17:32 ` [PATCH 1/4] dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat J. Neuschäfer
2024-12-13 17:32 ` J. Neuschäfer via B4 Relay
2024-12-20 12:53 ` Linus Walleij
2024-12-13 17:32 ` [PATCH 2/4] dt-bindings: gpio: fairchild,74hc595: Add latch-gpios property J. Neuschäfer
2024-12-13 17:32 ` J. Neuschäfer via B4 Relay
2024-12-17 15:25 ` Rob Herring
2024-12-19 12:44 ` J. Neuschäfer
2024-12-13 17:32 ` [PATCH 3/4] gpio: 74x164: Add On Semi MC74HC595A compat J. Neuschäfer
2024-12-13 17:32 ` J. Neuschäfer via B4 Relay
2024-12-20 12:54 ` Linus Walleij
2024-12-13 17:32 ` [PATCH 4/4] gpio: 74x164: Add latch GPIO support J. Neuschäfer
2024-12-13 17:32 ` J. Neuschäfer via B4 Relay
2024-12-16 18:20 ` J. Neuschäfer
2024-12-22 8:58 ` Linus Walleij
2024-12-24 7:26 ` J. Neuschäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2piHTP63SpaatHv@probook \
--to=j.ne@posteo.net \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.