From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, junjie.mao@hotmail.com
Subject: Re: [PATCH 04/12] rust: macros: check that #[derive(Object)] requires #[repr(C)]
Date: Thu, 26 Dec 2024 00:46:01 +0800 [thread overview]
Message-ID: <Z2w2yZ5RZdLxtkLl@intel.com> (raw)
In-Reply-To: <20241220142955.652636-5-pbonzini@redhat.com>
On Fri, Dec 20, 2024 at 03:29:46PM +0100, Paolo Bonzini wrote:
> Date: Fri, 20 Dec 2024 15:29:46 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 04/12] rust: macros: check that #[derive(Object)] requires
> #[repr(C)]
> X-Mailer: git-send-email 2.47.1
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/qemu-api-macros/src/lib.rs | 2 ++
> 1 file changed, 2 insertions(+)
>
LGTM,
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
(I think this patch would be best placed before patch 3. What do you
think?)
next prev parent reply other threads:[~2024-12-25 16:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 14:29 [PATCH 00/12] Next round of qemu_api patches Paolo Bonzini
2024-12-20 14:29 ` [PATCH 01/12] rust: qom: add ParentField Paolo Bonzini
2024-12-25 8:54 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 02/12] rust: add a utility module for compile-time type checks Paolo Bonzini
2024-12-25 16:24 ` Zhao Liu
2024-12-27 4:26 ` Paolo Bonzini
2024-12-20 14:29 ` [PATCH 03/12] rust: macros: check that the first field of a #[derive(Object)] struct is a ParentField Paolo Bonzini
2024-12-25 16:41 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 04/12] rust: macros: check that #[derive(Object)] requires #[repr(C)] Paolo Bonzini
2024-12-25 16:46 ` Zhao Liu [this message]
2024-12-20 14:29 ` [PATCH 05/12] rust: qom: automatically use Drop trait to implement instance_finalize Paolo Bonzini
2024-12-20 14:29 ` [PATCH 06/12] rust: qom: move device_id to PL011 class side Paolo Bonzini
2024-12-26 3:07 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 07/12] rust: pl011: only leave embedded object initialization in instance_init Paolo Bonzini
2024-12-26 3:20 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 08/12] rust: qom: make INSTANCE_POST_INIT take a shared reference Paolo Bonzini
2024-12-26 3:29 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 09/12] rust: qdev: expose inherited methods to subclasses of SysBusDevice Paolo Bonzini
2024-12-26 4:47 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 10/12] rust: qemu-api-macros: extend error reporting facility to parse errors Paolo Bonzini
2024-12-26 4:50 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 11/12] rust: qemu-api-macros: add automatic TryFrom/TryInto derivation Paolo Bonzini
2024-12-26 7:14 ` Zhao Liu
2024-12-20 14:29 ` [PATCH 12/12] rust: hide warnings for subprojects Paolo Bonzini
2024-12-26 7:21 ` Zhao Liu
2024-12-23 6:40 ` [PATCH 00/12] Next round of qemu_api patches Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2w2yZ5RZdLxtkLl@intel.com \
--to=zhao1.liu@intel.com \
--cc=junjie.mao@hotmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.