From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Chris Brandt <chris.brandt@renesas.com>,
Andi Shyti <andi.shyti@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v4 6/9] i2c: riic: Make use of devres helper to request deasserted reset line
Date: Thu, 9 Jan 2025 10:36:06 +0100 [thread overview]
Message-ID: <Z3-Yhg18VKreoOOi@shikoro> (raw)
In-Reply-To: <20250103091900.428729-7-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Fri, Jan 03, 2025 at 09:18:57AM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Simplify the `riic_i2c_probe()` function by using the
> `devm_reset_control_get_optional_exclusive_deasserted()` API to request a
> deasserted reset line. This eliminates the need to manually deassert the
> reset control and the additional cleanup.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Missed to give my tag here:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-01-09 9:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 9:18 [PATCH v4 0/9] i2c: riic: driver cleanup and improvements Prabhakar
2025-01-03 9:18 ` [PATCH v4 1/9] i2c: riic: Introduce a separate variable for IRQ Prabhakar
2025-01-03 10:47 ` Geert Uytterhoeven
2025-01-03 12:21 ` Lad, Prabhakar
2025-01-03 9:18 ` [PATCH v4 2/9] i2c: riic: Use dev_err_probe in probe and riic_init_hw functions Prabhakar
2025-01-03 9:18 ` [PATCH v4 3/9] i2c: riic: Use local `dev` pointer in `dev_err_probe()` Prabhakar
2025-01-03 9:18 ` [PATCH v4 4/9] i2c: riic: Use BIT macro consistently Prabhakar
2025-01-12 14:24 ` Andy Shevchenko
2025-01-13 8:09 ` Geert Uytterhoeven
2025-01-03 9:18 ` [PATCH v4 5/9] i2c: riic: Use GENMASK() macro for bitmask definitions Prabhakar
2025-01-12 14:25 ` Andy Shevchenko
2025-01-03 9:18 ` [PATCH v4 6/9] i2c: riic: Make use of devres helper to request deasserted reset line Prabhakar
2025-01-09 9:36 ` Wolfram Sang [this message]
2025-01-03 9:18 ` [PATCH v4 7/9] i2c: riic: Mark riic_irqs array as const Prabhakar
2025-01-09 9:36 ` Wolfram Sang
2025-01-03 9:18 ` [PATCH v4 8/9] i2c: riic: Use predefined macro and simplify clock tick calculation Prabhakar
2025-01-03 15:55 ` Geert Uytterhoeven
2025-01-09 9:41 ` Wolfram Sang
2025-01-09 9:45 ` Wolfram Sang
2025-01-12 14:29 ` Andy Shevchenko
2025-01-03 9:19 ` [PATCH v4 9/9] i2c: riic: Add `riic_bus_barrier()` to check bus availability Prabhakar
2025-01-03 16:09 ` Geert Uytterhoeven
2025-01-03 16:12 ` Lad, Prabhakar
2025-01-03 23:54 ` [PATCH v4 0/9] i2c: riic: driver cleanup and improvements Andi Shyti
2025-01-04 8:15 ` Lad, Prabhakar
2025-01-09 14:44 ` Andi Shyti
2025-01-09 14:50 ` Lad, Prabhakar
2025-01-12 14:27 ` Andy Shevchenko
2025-01-12 14:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3-Yhg18VKreoOOi@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=chris.brandt@renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.