From: Patrick Steinhardt <ps@pks.im>
To: Sam James <sam@gentoo.org>
Cc: git@vger.kernel.org, Eli Schwartz <eschwartz@gentoo.org>
Subject: Re: [PATCH] meson: fix perl dependencies
Date: Wed, 8 Jan 2025 07:22:55 +0100 [thread overview]
Message-ID: <Z34Zv55SSDexBxHQ@pks.im> (raw)
In-Reply-To: <371571630df201b0b0c680f6437decc6c60ecd3b.1736307757.git.sam@gentoo.org>
On Wed, Jan 08, 2025 at 03:42:37AM +0000, Sam James wrote:
> `generate_perl_command` needs `depends: [git_version_file]` and the uses
> in top-level meson.build were fine, but the ones in perl/ weren't, causing
> parallel build failures in some cases as GIT-BUILD-OPTIONS wasn't yet
> available.
Thanks for your patch! The change looks obviously correct to me.
Patrick
next prev parent reply other threads:[~2025-01-08 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 3:42 [PATCH] meson: fix perl dependencies Sam James
2025-01-08 6:22 ` Patrick Steinhardt [this message]
2025-01-08 16:07 ` Junio C Hamano
2025-01-08 16:13 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z34Zv55SSDexBxHQ@pks.im \
--to=ps@pks.im \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.