From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Christian Zigotzky <chzigotzky@xenosoft.de>,
linuxppc-dev@lists.ozlabs.org, regressions@lists.linux.dev
Subject: Re: [PATCH] KVM: allow NULL writable argument to __kvm_faultin_pfn
Date: Wed, 8 Jan 2025 06:41:34 -0800 [thread overview]
Message-ID: <Z36OnrAGOL9c7cku@google.com> (raw)
In-Reply-To: <Z3wnsQQ67GBf1Vsb@google.com>
On Mon, Jan 06, 2025, Sean Christopherson wrote:
> On Wed, Jan 01, 2025, Paolo Bonzini wrote:
> > kvm_follow_pfn() is able to work with NULL in the .map_writable field
> > of the homonymous struct. But __kvm_faultin_pfn() rejects the combo
> > despite KVM for e500 trying to use it. Indeed .map_writable is not
> > particularly useful if the flags include FOLL_WRITE and readonly
> > guest memory is not supported, so add support to __kvm_faultin_pfn()
> > for this case.
>
> I would prefer to keep the sanity check to minimize the risk of a page fault
> handler not supporting opportunistic write mappings. e500 is definitely the
> odd one out here.
Per a quick chat at PUCK, Paolo is going to try and fix the e500 code to actually
use the @writable param as it's intended.
next prev parent reply other threads:[~2025-01-08 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-01 6:49 [PATCH] KVM: allow NULL writable argument to __kvm_faultin_pfn Paolo Bonzini
2025-01-06 18:57 ` Sean Christopherson
2025-01-08 14:41 ` Sean Christopherson [this message]
2025-01-11 14:47 ` Christian Zigotzky
-- strict thread matches above, loose matches on Subject: below --
2025-01-11 14:49 Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z36OnrAGOL9c7cku@google.com \
--to=seanjc@google.com \
--cc=chzigotzky@xenosoft.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.