From: Daniel Thompson <danielt@kernel.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Borislav Petkov <bp@alien8.de>,
Brendan Higgins <brendan.higgins@linux.dev>,
Daniel Gomez <da.gomez@samsung.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Gow <davidgow@google.com>,
Douglas Anderson <dianders@chromium.org>,
Ingo Molnar <mingo@redhat.com>,
Jason Wessel <jason.wessel@windriver.com>,
Jiri Kosina <jikos@kernel.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
Johannes Berg <johannes@sipsolutions.net>,
Josh Poimboeuf <jpoimboe@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Miroslav Benes <mbenes@suse.cz>, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>, Petr Pavlu <petr.pavlu@suse.com>,
Rae Moar <rmoar@google.com>, Richard Weinberger <richard@nod.at>,
Sami Tolvanen <samitolvanen@google.com>,
Shuah Khan <shuah@kernel.org>, Song Liu <song@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
kgdb-bugreport@lists.sourceforge.net, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, linux-modules@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org,
live-patching@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 5/8] module: introduce MODULE_STATE_GONE
Date: Wed, 8 Jan 2025 15:43:48 +0000 [thread overview]
Message-ID: <Z36dNC2ROdNsaEyR@aspen.lan> (raw)
In-Reply-To: <20241227072825.1288491-6-rppt@kernel.org>
On Fri, Dec 27, 2024 at 09:28:22AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> In order to use execmem's API for temporal remapping of the memory
> allocated from ROX cache as writable, there is a need to distinguish
> between the state when the module is being formed and the state when it is
> deconstructed and freed so that when module_memory_free() is called from
> error paths during module loading it could restore ROX mappings.
>
> Replace open coded checks for MODULE_STATE_UNFORMED with a helper
> function module_is_formed() and add a new MODULE_STATE_GONE that will be
> set when the module is deconstructed and freed.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
I've seen the rest of the discussion about this patch... but in case I
forget, and from an extremely myopic kgdb/kdb point of view:
Acked-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Daniel.
next prev parent reply other threads:[~2025-01-08 15:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 7:28 [PATCH 0/8] x86/module: rework ROX cache to avoid writable copy Mike Rapoport
2024-12-27 7:28 ` [PATCH 1/8] x86/mm/pat: cpa-test: fix length for CPA_ARRAY test Mike Rapoport
2025-01-03 11:19 ` Peter Zijlstra
2024-12-27 7:28 ` [PATCH 2/8] x86/mm/pat: drop duplicate variable in cpa_flush() Mike Rapoport
2024-12-27 7:28 ` [PATCH 3/8] x86/mm/pat: Restore large pages after fragmentation Mike Rapoport
2025-01-10 10:36 ` Kirill A. Shutemov
2025-01-10 19:18 ` Luis Chamberlain
2025-01-12 8:54 ` Mike Rapoport
2025-01-13 8:01 ` Kirill A. Shutemov
2025-01-14 11:01 ` Mike Rapoport
2024-12-27 7:28 ` [PATCH 4/8] execmem: add API for temporal remapping as RW and restoring ROX afterwards Mike Rapoport
2024-12-27 7:28 ` [PATCH 5/8] module: introduce MODULE_STATE_GONE Mike Rapoport
2025-01-08 15:43 ` Daniel Thompson [this message]
2024-12-27 7:28 ` [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX Mike Rapoport
2025-01-02 21:30 ` Lorenzo Stoakes
2025-01-03 2:06 ` Andrew Cooper
2025-01-03 5:57 ` Andrew Morton
2025-01-03 10:57 ` Marek Marczykowski-Górecki
2025-01-03 6:58 ` Jürgen Groß
2025-01-04 2:07 ` Luis Chamberlain
2025-01-05 12:52 ` Marek Maślanka
2024-12-27 7:28 ` [PATCH 7/8] Revert "x86/module: prepare module loading for ROX allocations of text" Mike Rapoport
2024-12-27 7:28 ` [PATCH 8/8] module: drop unused module_writable_address() Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z36dNC2ROdNsaEyR@aspen.lan \
--to=danielt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bp@alien8.de \
--cc=brendan.higgins@linux.dev \
--cc=da.gomez@samsung.com \
--cc=dave.hansen@linux.intel.com \
--cc=davidgow@google.com \
--cc=dianders@chromium.org \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=jpoimboe@kernel.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=kirill.shutemov@linux.intel.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=pmladek@suse.com \
--cc=richard@nod.at \
--cc=rmoar@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.