From: Bill O'Donnell <bodonnel@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] sysv: Remove the filesystem
Date: Wed, 8 Jan 2025 16:32:55 -0600 [thread overview]
Message-ID: <Z379F9ymCnMB2vt2@redhat.com> (raw)
In-Reply-To: <20250107-wahrt-veredeln-84a1838928e8@brauner>
On Tue, Jan 07, 2025 at 03:35:35PM +0100, Christian Brauner wrote:
> On Mon, Jan 06, 2025 at 05:24:01PM +0100, Jan Kara wrote:
> > Since 2002 (change "Replace BKL for chain locking with sysvfs-private
> > rwlock") the sysv filesystem was doing IO under a rwlock in its
> > get_block() function (yes, a non-sleepable lock hold over a function
> > used to read inode metadata for all reads and writes). Nobody noticed
> > until syzbot in 2023 [1]. This shows nobody is using the filesystem.
> > Just drop it.
> >
> > [1] https://lore.kernel.org/all/0000000000000ccf9a05ee84f5b0@google.com/
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > What do people think about this? Or should we perhaps go through a (short)
> > deprecation period where we warn about removal?
>
> Let's try and kill it. We can always put it back if we have to.
>
So should any work toward converting sysv to the new mount API stop? ;)
Thanks-
Bill
next prev parent reply other threads:[~2025-01-08 22:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 16:24 [PATCH] sysv: Remove the filesystem Jan Kara
2025-01-06 19:52 ` Jeff Layton
2025-01-06 23:31 ` Darrick J. Wong
2025-01-07 7:17 ` Cedric Blancher
2025-01-07 10:08 ` Jan Kara
2025-01-07 15:13 ` Al Viro
2025-01-06 20:41 ` Matthew Wilcox
2025-01-07 14:35 ` Christian Brauner
2025-01-08 22:32 ` Bill O'Donnell [this message]
2025-01-09 15:05 ` Christian Brauner
2025-01-09 23:08 ` Bill O'Donnell
-- strict thread matches above, loose matches on Subject: below --
2025-02-20 16:39 Jan Kara
2025-02-20 18:50 ` Darrick J. Wong
2025-02-20 20:06 ` Jeff Layton
2025-02-21 9:38 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z379F9ymCnMB2vt2@redhat.com \
--to=bodonnel@redhat.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.