From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from diktynna.open-mesh.org (diktynna.open-mesh.org [136.243.236.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09A12E77188 for ; Mon, 30 Dec 2024 21:50:41 +0000 (UTC) Received: from diktynna.open-mesh.org (localhost [IPv6:::1]) by diktynna.open-mesh.org (Postfix) with ESMTP id 798DE83F69 for ; Mon, 30 Dec 2024 22:50:40 +0100 (CET) ARC-Seal: i=2; cv=pass; a=rsa-sha256; d=open-mesh.org; s=20121; t=1735595440; b=tAQ9dLvrQ7kKANYtP70tWXEy8wnHxr2JlsVRsOzUMM+E2kif2YzEQJa8lU0yf73gXgvs9 F9bC+ks1jVFcqBqdz8wVsczEZ4viUd3+fGdFbPnm8vk6OqeCwSlLvUY12jM3XuZGUWmZyZ4 HhPdG1E61n5GjiyscXN4szQaURjdleI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1735595440; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=glK/zyiFEzrFQMdxKAIJqSDKJ9espmpl0CI+rR8WRxQ=; b=zfl/DMhI3zjyHazQ0BrKNVR5Rd4HZktIqIVfrSZHesUGStCj38oCxj0039b/r4xkx9Z39 iUnZT4Jf7otQJulntzDMmEGfOtYebgoeovhYo6Xf6h36qZLuVt3p64I5gScmmhNo1lLVscd H4DzqnpepItHKYz8bpG5ow/ejF75Bv4= ARC-Authentication-Results: i=2; open-mesh.org; dkim=fail; arc=pass; dmarc=none Authentication-Results: open-mesh.org; dkim=fail; arc=pass; dmarc=none Received: from mail.aperture-lab.de (mail.aperture-lab.de [IPv6:2a01:4f8:c2c:665b::1]) by diktynna.open-mesh.org (Postfix) with ESMTPS id E3FE0819AE for ; Mon, 30 Dec 2024 22:50:26 +0100 (CET) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=open-mesh.org; s=20121; t=1735595427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=glK/zyiFEzrFQMdxKAIJqSDKJ9espmpl0CI+rR8WRxQ=; b=xXlycZzCjSAvQ3LhARUlU4S0dcgRLyKNA6ZDk2nQSK68DxJXOj5pZPsF38c7GSdSUzHUK8 uFucvhGd4b3laNv96I1GoP8ACGOwyPt5dl/D1cXCKuhV5MwI+dZJNn7KFE4pFY3f/qrYKX a8QkkfTTGwQ94HluyrFYFS/pF1VlVaw= ARC-Authentication-Results: i=1; diktynna.open-mesh.org; dkim=none; dmarc=none; spf=pass (diktynna.open-mesh.org: domain of linus.luessing@c0d3.blue designates 2a01:4f8:c2c:665b::1 as permitted sender) smtp.mailfrom=linus.luessing@c0d3.blue ARC-Seal: i=1; s=20121; d=open-mesh.org; t=1735595427; a=rsa-sha256; cv=none; b=1hR47PYyebChnmrEgkMvIghKIvE5yOrfSVE3puVhI9/TSkMp1UPLWgCwAGagAxrAiYRoVc tYFjwtZMKcQmaeR9LJPSbswJ33I7tQx9YZcLlGIEQ8WriLxd1r2KhyIay1gkCZ5+1ocwjb 2rWQZjck6NfeqNJQZ0iDLTLwUuQF7WE= Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3063854C92B; Mon, 30 Dec 2024 22:50:25 +0100 (CET) Date: Mon, 30 Dec 2024 22:50:25 +0100 From: Linus =?utf-8?Q?L=C3=BCssing?= To: Antonio Quartulli Cc: Sven Eckelmann , b.a.t.m.a.n@lists.open-mesh.org Subject: Re: [PATCH] batman-adv: Map VID 0 to untagged TT VLAN Message-ID: References: <20241216-no-vlan-0-v1-1-62586f97fd88@narfation.org> <2224062.Icojqenx9y@sven-l14> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Message-ID-Hash: FXGEZJK34WPBECFBAFR6VC62UNBX2OR2 X-Message-ID-Hash: FXGEZJK34WPBECFBAFR6VC62UNBX2OR2 X-MailFrom: linus.luessing@c0d3.blue X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-b.a.t.m.a.n.lists.open-mesh.org-0; header-match-b.a.t.m.a.n.lists.open-mesh.org-1; header-match-b.a.t.m.a.n.lists.open-mesh.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: The list for a Better Approach To Mobile Ad-hoc Networking Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Dec 18, 2024 at 09:02:27AM +0100, Antonio Quartulli wrote: > I am not aware of 0 being used as a sane VID. > I have seen it mostly used internally, but never truly used with something > like "eth0.0". > > Therefore I agree with Sven that this should not cause any real compat > issue. If we truly break something, then we can probably assume that the > scenario was already ill formed. Ok, thanks you two for elaborating on this. Ok, these are good points. If no one uses VLAN 0 (in some partially broken/worked around/ out-of-spec way) and no one screams right now then I also like this change. And would probably make sense to make this change now, before adding (some) VLAN learning to batman-adv. Where otherwise potentially less informed, random user (compared to node administrators?) would otherwise more likely use VLAN 0 in an unintended/out-of-spec way.