From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Wolfram Sang <wsa@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v3 2/4] i2c: Replace list-based mechanism for handling auto-detected clients
Date: Fri, 3 Jan 2025 13:29:14 +0100 [thread overview]
Message-ID: <Z3fYGvxAs5HkUx_P@shikoro> (raw)
In-Reply-To: <ad839a82-8694-4f99-b1c1-0ee53c9d40cf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On Fri, Nov 01, 2024 at 11:09:51PM +0100, Heiner Kallweit wrote:
> So far a list is used to track auto-detected clients per driver.
> The same functionality can be achieved much simpler by flagging
> auto-detected clients.
>
> Two notes regarding the usage of driver_for_each_device:
> In our case it can't fail, however the function is annotated __must_check.
> So a little workaround is needed to avoid a compiler warning.
> Then we may remove nodes from the list over which we iterate.
> This is safe, see the explanation at the beginning of lib/klist.c.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-next, thanks! One minor edit:
> +#define I2C_CLIENT_AUTO 0x100 /* for board_info; auto-detected */
This is not for 'board_info'. I changed it to "client was
auto-detected".
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-01-03 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 22:05 [PATCH v3 0/4] i2c: Replace lists of special clients with flagging of such clients Heiner Kallweit
2024-11-01 22:07 ` [PATCH v3 1/4] ALSA: ppc: Remove i2c client removal hack Heiner Kallweit
2025-01-03 12:28 ` Wolfram Sang
2024-11-01 22:09 ` [PATCH v3 2/4] i2c: Replace list-based mechanism for handling auto-detected clients Heiner Kallweit
2025-01-03 12:29 ` Wolfram Sang [this message]
2025-02-04 15:24 ` Herve Codina
2025-02-04 20:00 ` Heiner Kallweit
2024-11-01 22:11 ` [PATCH v3 3/4] i2c: Replace list-based mechanism for handling userspace-created clients Heiner Kallweit
2025-01-03 12:35 ` Wolfram Sang
2024-11-01 22:12 ` [PATCH v3 4/4] i2c: core: Remove obsolete members of i2c_adapter and i2c_client Heiner Kallweit
2025-01-03 12:36 ` Wolfram Sang
2024-11-24 15:48 ` [PATCH v3 0/4] i2c: Replace lists of special clients with flagging of such clients Wolfram Sang
2025-01-03 12:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3fYGvxAs5HkUx_P@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.