From: Mike Snitzer <snitzer@hammerspace.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Mohammed Anees <pvmohammedanees2003@gmail.com>,
agk@redhat.com, dm-devel@lists.linux.dev,
linux-kernel@vger.kernel.org, zkabelac@redhat.com
Subject: Re: dm: Allow the use of escaped characters in str_field_delimit()
Date: Mon, 6 Jan 2025 16:27:07 -0500 [thread overview]
Message-ID: <Z3xKkYyNCQaRqzjZ@hammerspace.com> (raw)
In-Reply-To: <034eaa34-1737-6f75-2227-4e0dfbc753cf@redhat.com>
On Fri, Jan 03, 2025 at 05:21:13PM +0100, Mikulas Patocka wrote:
>
>
> On Sun, 15 Dec 2024, Mohammed Anees wrote:
>
> > > It would seem Mohammed cared enough to write the patch, but not reply
> > > to you with further clarification on why it needed...
> >
> > I thought I had already replied to the concern, but it seems
> > the message didn´t get sent, apologies for that oversight!
> > College academics kept me tied up, and I lost track of this,
> > apologies once again.
> >
> > > BUT, in this instance it follows that: if lvm2 is allowing weird names
> > > which require escacped characters _and_ dm-init is used then dm-init
> > > needs to support handling them (dm-init is all about _not_ using
> > > normal initramfs with lvm2 in all its glory).
> >
> > I completely agree with your point and am more than happy to
> > provide further details or make any additional updates to
> > the patch if needed, please let me know if anything else if needed.
> > Thank you for your time.
> >
> > Regards
> > Mohammed Anees
>
> Hi
>
> I don't want to bloat the code with the logic that no one uses. I would
> only accept the patch if there were some real scenario where you need to
> use escaped characters in device names or table parameters.
Please read my reply in this thread (which you quoted above). The
real scenario was already answered.
Either:
1) remove dm-init entirely
or
2) fix it so that it works with naming that requires escaped
characters
or
3) say: "sorry, dm-init doesn't support escaped characters."
prev parent reply other threads:[~2025-01-06 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 17:57 [PATCH] dm: Allow the use of escaped characters in str_field_delimit() Mohammed Anees
2024-11-13 10:39 ` Zdenek Kabelac
2024-11-18 10:38 ` Mikulas Patocka
2024-12-10 16:25 ` Mike Snitzer
2024-12-15 10:13 ` Mohammed Anees
2025-01-03 16:21 ` Mikulas Patocka
2025-01-06 21:27 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3xKkYyNCQaRqzjZ@hammerspace.com \
--to=snitzer@hammerspace.com \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=pvmohammedanees2003@gmail.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.