From: Oliver Upton <oliver.upton@linux.dev>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: kvmarm@lists.linux.dev, maz@kernel.org, joey.gouly@arm.com,
tabba@google.com
Subject: Re: [PATCH] KVM: arm64: Fix FEAT_MOPS in pKVM
Date: Mon, 6 Jan 2025 15:20:47 -0800 [thread overview]
Message-ID: <Z3xlT51luMieOAab@linux.dev> (raw)
In-Reply-To: <20250106112329.64013-1-vladimir.murzin@arm.com>
+cc Fuad
On Mon, Jan 06, 2025 at 11:23:29AM +0000, Vladimir Murzin wrote:
> Flush HCRX_EL2 when switching between the host and the guests.
>
> Fixes: 84de212d739e ("KVM: arm64: Make FEAT_MOPS UNDEF if not advertised to the guest")
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
We shouldn't be trusting the host's hcrx_el2 in this case and should
instead calculate it for the pVM similar to the other trap registers
(see pkvm_vcpu_init_traps() and friends).
It is apparent, though, that we erroneously exposed MOPS before commit
3d7ff00700d1 ("KVM: arm64: Rework specifying restricted features for protected VMs").
--
Thanks,
Oliver
next prev parent reply other threads:[~2025-01-06 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 11:23 [PATCH] KVM: arm64: Fix FEAT_MOPS in pKVM Vladimir Murzin
2025-01-06 23:20 ` Oliver Upton [this message]
2025-01-07 8:08 ` Fuad Tabba
2025-01-07 9:59 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3xlT51luMieOAab@linux.dev \
--to=oliver.upton@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=tabba@google.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.