From: Sabrina Dubroca <sd@queasysnail.net>
To: Ales Nezbeda <anezbeda@redhat.com>
Cc: netdev@vger.kernel.org, mayflowerera@gmail.com
Subject: Re: [PATCH net-next] net: macsec: Add endianness annotations in salt struct
Date: Mon, 20 Jan 2025 00:19:53 +0100 [thread overview]
Message-ID: <Z42Imd8YTQbZL8va@hog> (raw)
In-Reply-To: <20250117112228.90948-1-anezbeda@redhat.com>
2025-01-17, 12:22:28 +0100, Ales Nezbeda wrote:
> This change resolves warning produced by sparse tool as currently
> there is a mismatch between normal generic type in salt and endian
> annotated type in macsec driver code. Endian annotated types should
> be used here.
>
> Sparse output:
> warning: restricted ssci_t degrades to integer
> warning: incorrect type in assignment (different base types)
> expected restricted ssci_t [usertype] ssci
> got unsigned int
> warning: restricted __be64 degrades to integer
> warning: incorrect type in assignment (different base types)
> expected restricted __be64 [usertype] pn
> got unsigned long long
>
> Signed-off-by: Ales Nezbeda <anezbeda@redhat.com>
> ---
> include/net/macsec.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
--
Sabrina
next prev parent reply other threads:[~2025-01-19 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 11:22 [PATCH net-next] net: macsec: Add endianness annotations in salt struct Ales Nezbeda
2025-01-17 18:18 ` Simon Horman
2025-01-19 23:19 ` Sabrina Dubroca [this message]
2025-01-20 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z42Imd8YTQbZL8va@hog \
--to=sd@queasysnail.net \
--cc=anezbeda@redhat.com \
--cc=mayflowerera@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.