From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Gwendal Grignou <gwendal@chromium.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v3] iio: cros_ec: Trace EC sensors command
Date: Mon, 20 Jan 2025 08:50:49 +0000 [thread overview]
Message-ID: <Z44OaSCdFeCygJLQ@google.com> (raw)
In-Reply-To: <20250118162748.6badf0ab@jic23-huawei>
On Sat, Jan 18, 2025 at 04:33:52PM +0000, Jonathan Cameron wrote:
> I briefly applied this, but...
>
> [jic23@jic23-huawei iio]$ make LOCALVERSION= W=1 -j12 C=1
> mkdir -p /home/jic23/src/kernel/iio/tools/objtool && make O=/home/jic23/src/kernel/iio subdir=tools/objtool --no-print-directory -C objtool
> CALL scripts/checksyscalls.sh
> INSTALL libsubcmd_headers
> CC [M] drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.o
> CC [M] drivers/iio/common/cros_ec_sensors/cros_ec_sensors_trace.o
> In file included from drivers/iio/common/cros_ec_sensors/cros_ec_sensors_trace.h:56,
> from drivers/iio/common/cros_ec_sensors/cros_ec_sensors_trace.c:32:
> ./include/trace/define_trace.h:106:42: fatal error: ./cros_ec_sensors_trace.h: No such file or directory
> 106 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> | ^
>
> Despite dealing with trace points a lot in the day job
> I still find them hard to actually add to a subsystem because
> of fun things like this one.
Weird, I did the same test without seeing the error:
$ make O=build_dir W=1 allmodconfig \
drivers/iio/common/cros_ec_sensors/cros-ec-sensors-core.o
...
CC [M] drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.o
CC [M] drivers/iio/common/cros_ec_sensors/cros_ec_sensors_trace.o
LD [M] drivers/iio/common/cros_ec_sensors/cros-ec-sensors-core.o
next prev parent reply other threads:[~2025-01-20 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 23:01 [PATCH v3] iio: cros_ec: Trace EC sensors command Gwendal Grignou
2025-01-18 16:33 ` Jonathan Cameron
2025-01-20 8:50 ` Tzung-Bi Shih [this message]
2025-01-21 21:54 ` Gwendal Grignou
2025-01-22 6:06 ` Tzung-Bi Shih
2025-01-22 19:03 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z44OaSCdFeCygJLQ@google.com \
--to=tzungbi@kernel.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.