From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf symbol-elf: Avoid a weak cxx_demangle_sym function
Date: Thu, 9 Jan 2025 18:12:26 -0300 [thread overview]
Message-ID: <Z4A7uhizNDptyxNE@x1> (raw)
In-Reply-To: <CAP-5=fWBEGj-bKnfF3bi+qy3nzrV+oWzDj-0M5bRe2kQSsJ2Tw@mail.gmail.com>
On Thu, Jan 09, 2025 at 09:58:34AM -0800, Ian Rogers wrote:
> On Mon, Nov 18, 2024 at 7:17 PM Ian Rogers <irogers@google.com> wrote:
> >
> > cxx_demangle_sym is weak in case demangle-cxx.c replaces the
> > definition in symbol-elf.c. When demangle-cxx.c is built
> > HAVE_CXA_DEMANGLE_SUPPORT is defined, as such the define can be used
> > to avoid a weak symbol. As weak symbols are outside of the C standard
> > their use can lead to strange behaviors, in particular with LTO, as
> > well as causing issues to be hidden at link time.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Ping.
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2025-01-09 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 3:17 [PATCH v1] perf symbol-elf: Avoid a weak cxx_demangle_sym function Ian Rogers
2025-01-09 17:58 ` Ian Rogers
2025-01-09 21:12 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4A7uhizNDptyxNE@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.