From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH v3 4/7] migration: Rename vmstate_info_nullptr
Date: Thu, 9 Jan 2025 14:10:04 -0500 [thread overview]
Message-ID: <Z4AfDIkIdxIdQCYZ@x1n> (raw)
In-Reply-To: <20250109185249.23952-5-farosas@suse.de>
On Thu, Jan 09, 2025 at 03:52:46PM -0300, Fabiano Rosas wrote:
> Rename vmstate_info_nullptr from "uint64_t" to "nullptr". This vmstate
> actually reads and writes just a byte, so the proper name would be
> uint8. However, since this is a marker for a NULL pointer, it's
> convenient to have a more explicit name that can be identified by the
> consumers of the JSON part of the stream.
>
> Change the name to "nullptr" and add support for it in the
> analyze-migration.py script. Arbitrarily use the name of the type as
> the value of the field to avoid the script showing 0x30 or '0', which
> could be confusing for readers.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2025-01-09 19:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 18:52 [PATCH v3 0/7] migration: Fix s390 regressions + migration script Fabiano Rosas
2025-01-09 18:52 ` [PATCH v3 1/7] migration: Add more error handling to analyze-migration.py Fabiano Rosas
2025-01-09 18:52 ` [PATCH v3 2/7] migration: Remove unused argument in vmsd_desc_field_end Fabiano Rosas
2025-01-09 18:52 ` [PATCH v3 3/7] migration: Fix parsing of s390 stream Fabiano Rosas
2025-01-12 13:06 ` Michael Tokarev
2025-01-12 14:29 ` Michael Tokarev
2025-01-13 6:39 ` Thomas Huth
2025-01-13 7:51 ` Michael Tokarev
2025-01-13 8:19 ` Thomas Huth
2025-01-13 9:09 ` Michael Tokarev
2025-01-13 13:03 ` Fabiano Rosas
2025-01-13 13:07 ` Fabiano Rosas
2025-01-13 15:13 ` Michael Tokarev
2025-01-09 18:52 ` [PATCH v3 4/7] migration: Rename vmstate_info_nullptr Fabiano Rosas
2025-01-09 19:10 ` Peter Xu [this message]
2025-01-09 18:52 ` [PATCH v3 5/7] migration: Dump correct JSON format for nullptr replacement Fabiano Rosas
2025-01-09 18:52 ` [PATCH v3 6/7] migration: Fix arrays of pointers in JSON writer Fabiano Rosas
2025-01-09 19:10 ` Peter Xu
2025-01-09 18:52 ` [PATCH v3 7/7] s390x: Fix CSS migration Fabiano Rosas
2025-01-12 14:34 ` Michael Tokarev
2025-01-13 6:37 ` Thomas Huth
2025-01-12 14:34 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4AfDIkIdxIdQCYZ@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.