From: Sabrina Dubroca <sd@queasysnail.net>
To: Antoine Tenart <atenart@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Menglong Dong <menglong8.dong@gmail.com>
Subject: Re: [PATCH net] ipv4: route: fix drop reason being overridden in ip_route_input_slow
Date: Thu, 9 Jan 2025 23:29:52 +0100 [thread overview]
Message-ID: <Z4BN4EHgHcLhxoz1@hog> (raw)
In-Reply-To: <20250108165725.404564-1-atenart@kernel.org>
2025-01-08, 17:57:15 +0100, Antoine Tenart wrote:
> When jumping to 'martian_destination' a drop reason is always set but
> that label falls-through the 'e_nobufs' one, overriding the value.
[...]
> A 'goto out' is clearly missing now after 'martian_destination' to avoid
> overriding the drop reason.
>
> Fixes: 5b92112acd8e ("net: ip: make ip_route_input_slow() return drop reasons")
> Reported-by: Sabrina Dubroca <sd@queasysnail.net>
> Cc: Menglong Dong <menglong8.dong@gmail.com>
> Signed-off-by: Antoine Tenart <atenart@kernel.org>
> ---
> net/ipv4/route.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Thanks Antoine.
--
Sabrina
next prev parent reply other threads:[~2025-01-09 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 16:57 [PATCH net] ipv4: route: fix drop reason being overridden in ip_route_input_slow Antoine Tenart
2025-01-09 22:29 ` Sabrina Dubroca [this message]
2025-01-10 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4BN4EHgHcLhxoz1@hog \
--to=sd@queasysnail.net \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.