Re: [PATCH net-next 04/10] bnxt_en: Refactor completion ring free routine

[Michal Swiatkowski <michal.swiatkowski@linux.intel.com>]

On Sun, Jan 12, 2025 at 10:39:21PM -0800, Michael Chan wrote:
> From: Somnath Kotur <somnath.kotur@broadcom.com>
> 
> Add a wrapper routine to free L2 completion rings.  This will be
> useful later in the series.
> 
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 ++++++++++++++---------
>  1 file changed, 16 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index e9a2e30c1537..4c5cb4dd7420 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -7378,6 +7378,20 @@ static void bnxt_hwrm_rx_agg_ring_free(struct bnxt *bp,
>  	bp->grp_info[grp_idx].agg_fw_ring_id = INVALID_HW_RING_ID;
>  }
>  
> +static void bnxt_hwrm_cp_ring_free(struct bnxt *bp,
> +				   struct bnxt_cp_ring_info *cpr)
> +{
> +	struct bnxt_ring_struct *ring;
> +
> +	ring = &cpr->cp_ring_struct;
> +	if (ring->fw_ring_id == INVALID_HW_RING_ID)
> +		return;
> +
> +	hwrm_ring_free_send_msg(bp, ring, RING_FREE_REQ_RING_TYPE_L2_CMPL,
> +				INVALID_HW_RING_ID);
> +	ring->fw_ring_id = INVALID_HW_RING_ID;
> +}
> +
>  static void bnxt_hwrm_ring_free(struct bnxt *bp, bool close_path)
>  {
>  	u32 type;
> @@ -7423,17 +7437,9 @@ static void bnxt_hwrm_ring_free(struct bnxt *bp, bool close_path)
>  		struct bnxt_ring_struct *ring;
>  		int j;
>  
> -		for (j = 0; j < cpr->cp_ring_count && cpr->cp_ring_arr; j++) {
> -			struct bnxt_cp_ring_info *cpr2 = &cpr->cp_ring_arr[j];
> +		for (j = 0; j < cpr->cp_ring_count && cpr->cp_ring_arr; j++)
> +			bnxt_hwrm_cp_ring_free(bp, &cpr->cp_ring_arr[j]);
>  
> -			ring = &cpr2->cp_ring_struct;
> -			if (ring->fw_ring_id == INVALID_HW_RING_ID)
> -				continue;
> -			hwrm_ring_free_send_msg(bp, ring,
> -						RING_FREE_REQ_RING_TYPE_L2_CMPL,
> -						INVALID_HW_RING_ID);
> -			ring->fw_ring_id = INVALID_HW_RING_ID;
> -		}
>  		ring = &cpr->cp_ring_struct;
>  		if (ring->fw_ring_id != INVALID_HW_RING_ID) {
>  			hwrm_ring_free_send_msg(bp, ring, type,
> -- 
> 2.30.1

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>