From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
matttbe@kernel.org, martineau@kernel.org, geliang@kernel.org,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
mptcp@lists.linux.dev
Subject: Re: [PATCH net-next v2 1/2] net: remove init_dummy_netdev()
Date: Mon, 13 Jan 2025 13:58:47 -0800 [thread overview]
Message-ID: <Z4WMl6PvgRFRQEMm@LQ3V64L9R2> (raw)
In-Reply-To: <20250113003456.3904110-1-kuba@kernel.org>
On Sun, Jan 12, 2025 at 04:34:55PM -0800, Jakub Kicinski wrote:
> init_dummy_netdev() can initialize statically declared or embedded
> net_devices. Such netdevs did not come from alloc_netdev_mqs().
> After recent work by Breno, there are the only two cases where
> we have do that.
>
> Switch those cases to alloc_netdev_mqs() and delete init_dummy_netdev().
> Dealing with static netdevs is not worth the maintenance burden.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v2: change of plan, delete init_dummy_netdev() completely
> v1: https://lore.kernel.org/20250111065955.3698801-1-kuba@kernel.org
> ---
> CC: matttbe@kernel.org
> CC: martineau@kernel.org
> CC: geliang@kernel.org
> CC: steffen.klassert@secunet.com
> CC: herbert@gondor.apana.org.au
> CC: mptcp@lists.linux.dev
> ---
> include/linux/netdevice.h | 1 -
> net/core/dev.c | 22 ----------------------
> net/mptcp/protocol.c | 8 +++++---
> net/xfrm/xfrm_input.c | 9 ++++++---
> 4 files changed, 11 insertions(+), 29 deletions(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-01-13 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 0:34 [PATCH net-next v2 1/2] net: remove init_dummy_netdev() Jakub Kicinski
2025-01-13 0:34 ` [PATCH net-next v2 2/2] net: cleanup init_dummy_netdev_core() Jakub Kicinski
2025-01-13 22:00 ` Joe Damato
2025-01-13 12:14 ` [PATCH net-next v2 1/2] net: remove init_dummy_netdev() Alexander Lobakin
2025-01-13 16:16 ` Matthieu Baerts
2025-01-13 21:58 ` Joe Damato [this message]
2025-01-14 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4WMl6PvgRFRQEMm@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.