All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Scott Chacon via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Scott Chacon <schacon@gmail.com>
Subject: Re: [PATCH] help: interpret help.autocorrect=1 as "immediate" rather than 0.1s
Date: Mon, 13 Jan 2025 18:33:48 -0500	[thread overview]
Message-ID: <Z4Wi3K8Hd41VWWmG@nand.local> (raw)
In-Reply-To: <7553dc2b-7b91-31c9-e86e-aa24d3bb4235@gmx.de>

On Thu, Jan 09, 2025 at 01:18:15AM +0100, Johannes Schindelin wrote:
> For the record, I do think it was a mistake to treat number values as
> "deciseconds" here, it is inconsistent with pretty much any other config
> setting. But I also don't see any way to remediate this design mistake at
> this stage.

I almost made this same mistake when working on pseudo-merge bitmaps, in
particular with the non-integral configuration options like:

  - bitampPseudoMerge.<name>.decay
  - bitampPseudoMerge.<name>.sampleRate

If memory serves, I think this mostly had to do with the lack of a
double parser in the config system. I ended up adding one in 5831f8ac41
(config: introduce `git_config_double()`, 2024-05-23), and made those
configuration options take values like '0.1', etc.

I think it may be worth considering what "starting from scratch" would
look like, as Junio suggested above. To be clear, I think that that
should happen outside of the current patch and not hold it up, as what
Scott is proposing is a strict improvement.

But it may be worth thinking about what a different interface might look
like. If we settle on something we like, perhaps we could start nudging
users towards it and "deprecate" the existing syntax.

> Thank you for working on this and making the feature at least a little bit
> more usable.

I concur.

Thanks,
Taylor

  reply	other threads:[~2025-01-13 23:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 19:31 [PATCH] help: interpret help.autocorrect=1 as "immediate" rather than 0.1s Scott Chacon via GitGitGadget
2025-01-08 21:42 ` Kristoffer Haugsbakk
2025-01-09  0:18 ` Johannes Schindelin
2025-01-13 23:33   ` Taylor Blau [this message]
2025-01-09  1:12 ` Junio C Hamano
2025-01-09  7:05 ` Yongmin
2025-01-09 10:49 ` [PATCH v2] help: interpret boolean string values for help.autocorrect Scott Chacon via GitGitGadget
2025-01-09 16:32   ` Junio C Hamano
2025-01-10  7:43     ` Scott Chacon
2025-01-10  9:30       ` Scott Chacon
2025-01-10 12:11         ` Jeff King
2025-01-10 15:02           ` Junio C Hamano
2025-01-11 11:27   ` [PATCH v3] " Scott Chacon via GitGitGadget
2025-01-13  5:43     ` Jeff King
2025-01-13  9:31       ` Scott Chacon
2025-01-13 16:18       ` Junio C Hamano
2025-01-18  1:12         ` Junio C Hamano
2025-01-13  9:33     ` [PATCH v4] " Scott Chacon via GitGitGadget
2025-02-01 21:33       ` [PATCH 1/2] help: show the suggested command when help.autocorrect is false David Aguilar
2025-02-01 21:33         ` [PATCH 2/2] help: add "show" as a valid configuration value David Aguilar
2025-02-03 22:53           ` Junio C Hamano
2025-02-03 22:53         ` [PATCH 1/2] help: show the suggested command when help.autocorrect is false Junio C Hamano
2025-02-04  3:05           ` Jeff King
2025-02-04 13:38             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4Wi3K8Hd41VWWmG@nand.local \
    --to=me@ttaylorr.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=schacon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.