From: Patrick Steinhardt <ps@pks.im>
To: Sam James <sam@gentoo.org>
Cc: git@vger.kernel.org, Eli Schwartz <eschwartz@gentoo.org>
Subject: Re: [PATCH v3] meson: fix missing deps for technical articles
Date: Tue, 14 Jan 2025 16:01:06 +0100 [thread overview]
Message-ID: <Z4Z8Mg2IME0mveHJ@pks.im> (raw)
In-Reply-To: <5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736866030.git.sam@gentoo.org>
On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:
> We need an explicit `depends: documentation_deps` so that all of our
> Documentation targets know they require asciidoc.conf. This shows up
> as parallel build failures with it not yet being available.
>
> Other targets look OK already.
>
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
> v3: Fixed commit message.
> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.
Thanks, this version looks good to me.
Patrick
next prev parent reply other threads:[~2025-01-14 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 14:47 [PATCH v3] meson: fix missing deps for technical articles Sam James
2025-01-14 15:01 ` Patrick Steinhardt [this message]
2025-01-14 15:09 ` Sam James
2025-01-14 19:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4Z8Mg2IME0mveHJ@pks.im \
--to=ps@pks.im \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.