From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Wolfram Sang <wsa@kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: core: Improve i2c_new_scanned_device
Date: Tue, 14 Jan 2025 13:11:56 +0100 [thread overview]
Message-ID: <Z4ZUjLg3i8Boo3Q1@shikoro> (raw)
In-Reply-To: <e2c24c59-24c1-4694-bab3-c163d1579ba6@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
> No functional change is intended. I have hw using i801, which calls
> i2c_register_spd() -> i2c_new_scanned_device(). With this patch
> tools like decode-dimms still work.
Thanks. Still, thinking more about it, I am not comfortable with this
patch. Kernel code where the intended exit of a function is not at the
end but somewhere in the middle often enough confused me in the past.
So, although it is not as concise as your suggestion, I would prefer to
leave the code as-is for clarity.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-01-14 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 20:29 [PATCH] i2c: core: Improve i2c_new_scanned_device Heiner Kallweit
2025-01-09 10:27 ` Wolfram Sang
2025-01-09 13:58 ` Heiner Kallweit
2025-01-14 12:11 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4ZUjLg3i8Boo3Q1@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.