From: Roman Gushchin <roman.gushchin@linux.dev>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org,
yosryahmed@google.com, shakeel.butt@linux.dev,
muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz,
mkoutny@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
chenridong@huawei.com, wangweiyang2@huawei.com
Subject: Re: [PATCH -v2 next 2/4] memcg: call the free function when allocation of pn fails
Date: Tue, 14 Jan 2025 18:36:56 +0000 [thread overview]
Message-ID: <Z4auyCo_V4e-2GU3@google.com> (raw)
In-Reply-To: <20250114122519.1404275-3-chenridong@huaweicloud.com>
On Tue, Jan 14, 2025 at 12:25:17PM +0000, Chen Ridong wrote:
> From: Chen Ridong <chenridong@huawei.com>
>
> The 'free_mem_cgroup_per_node_info' function is used to free
> the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the
> free_mem_cgroup_per_node_info function will be much clearer.
> Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info'
> fails, to free 'pn' as a whole, which makes the code more cohesive.
>
> Signed-off-by: Chen Ridong <chenridong@huawei.com>
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
next prev parent reply other threads:[~2025-01-14 18:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 12:25 [PATCH -v2 next 0/4] Some cleanup for memcg Chen Ridong
2025-01-14 12:25 ` [PATCH -v2 next 1/4] memcg: use OFP_PEAK_UNSET instead of -1 Chen Ridong
2025-01-14 18:36 ` Roman Gushchin
2025-01-14 12:25 ` [PATCH -v2 next 2/4] memcg: call the free function when allocation of pn fails Chen Ridong
2025-01-14 18:36 ` Roman Gushchin [this message]
2025-01-14 12:25 ` [PATCH -v2 next 3/4] memcg: factor out the replace_stock_objcg function Chen Ridong
2025-01-14 18:39 ` Roman Gushchin
2025-01-16 0:56 ` Shakeel Butt
2025-01-14 12:25 ` [PATCH -v2 next 4/4] memcg: factor out stat(event)/stat_local(event_local) reading functions Chen Ridong
2025-01-14 18:45 ` Roman Gushchin
2025-01-16 0:57 ` Shakeel Butt
2025-01-16 1:21 ` Chen Ridong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4auyCo_V4e-2GU3@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=chenridong@huaweicloud.com \
--cc=davidf@vimeo.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=vbabka@suse.cz \
--cc=wangweiyang2@huawei.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.