From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64793E77188 for ; Tue, 14 Jan 2025 23:26:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0729D41583; Tue, 14 Jan 2025 23:26:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DM0dwDV_iZaS; Tue, 14 Jan 2025 23:26:11 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 020AD41581 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1736897171; bh=NV4PmVLk16CjHPkaMxzQZluPn2DMGP8myx2jLb4e+Pg=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qiuVIrvoqHQEjYlzh60Sj9opJVtiG7oVP30NTpO/cln6UOdQTqRkE6p5JRmyr5h5n dfczAGsxFSQtFExBqowqnt7wB0G+Yrn/1dVPa4kFdeoTlZOZPbFsAVPSkq2biM+hu9 V5w7RCfVgTAnwyCSzXMJ6VMbpd/VmNn7efKl4cWkQmO43C3aspCKzrhqF0UGtX7U7V VEPsi7iI0+REaLrVlXQs0s5BlNsKkdvizSE20P3q2TJ8/DjYdmrgpGDotXwZhWxJ9N RZisgy8GjS5PzsD73VIbXPSL41wQlaI/XAhcJUN24jpv442o/9vG246Kr3ZCkawI9e aqJGC0t6kMZMw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 020AD41581; Tue, 14 Jan 2025 23:26:11 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 7ACAF94B for ; Tue, 14 Jan 2025 23:26:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5AE4B610DB for ; Tue, 14 Jan 2025 23:26:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id uPn0JJbAH0Ju for ; Tue, 14 Jan 2025 23:26:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::62c; helo=mail-pl1-x62c.google.com; envelope-from=jdamato@fastly.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 54A6F610D9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 54A6F610D9 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by smtp3.osuosl.org (Postfix) with ESMTPS id 54A6F610D9 for ; Tue, 14 Jan 2025 23:26:06 +0000 (UTC) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-21634338cfdso101300025ad.2 for ; Tue, 14 Jan 2025 15:26:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736897165; x=1737501965; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NV4PmVLk16CjHPkaMxzQZluPn2DMGP8myx2jLb4e+Pg=; b=FFoN7W8pEUrjV6GtZtE8sPZJnDGkogGuL7o/KkCIGnYF+/tir8wNC8vcdqVAgut3NA NlYvsirxBEAeCMpv+JI3oKskzL1bDFUR6LLnTEuQMy5iUK3jnOnG9bNZd2CQagzRqBdS qCvUimvEfoKVkguMToM3AHe7yi9DxxY8g0YUpD1FS9Rf+GxRfvQveS5EmpGLKN8y4OHi VOnh13/vU19cuDS9ZA4Q8nJDSfqFimAk/bgQ0Rx3zxBNy5LFEX7Okud6rr1soWU2787m zmzi2KcWTYYuCY9zM6Z53yf2NP8P2F4Lg7TKA0mLk/AL/nNxaha9Uwipn2wzjHNCK098 xNlA== X-Forwarded-Encrypted: i=1; AJvYcCUdaLw7YLQKK6g69MPyMxsqgvHM729Tq81BYD62CTAF41L8cLSulkvtMPZgRwEd6tKchapxvYhBI7nyZrDqgH8=@lists.osuosl.org X-Gm-Message-State: AOJu0YzSpfpVCmo4OX2/nz7Rm6m6aHd7QyVBplP6UCI0VSUjjRp3M3J3 KpsblSMTKmSn91ZYRdsGFRIw9JlOj9vlKMRceoz96phGB0PyeJYhNsrt9dZ8nUt3yrhXY5KknV7 y X-Gm-Gg: ASbGncsppvC6tomgitl4dXR2vIvmJ6lxjDFcry8oVULN6PAFJAYr7NVmB04RWKLultm BXAo+juuNg6ypQ4XbU2VrjbvnnlO89br0Qm8RzF3f4o+dlHJFwVIGsE8Se/lE6PFPNFBxHSuYHx UJskxrLbyeyq+Amwj+Vl6d/9pgrfpNPLm6fd1NdO17ZSkCQ14tsQbFtlqOAI0lYixu2XQpoSzlY dri1New/0v2U4h3oywLt5cU9fHWX6wfXOp5LYIRKxgtPFnRvsGFzxQsCebHa8b6/EjRq+kpxk+y 7ePnbI8/HSwYTiY/k4Tz6PA= X-Google-Smtp-Source: AGHT+IHFPFr5ciMlkXuJKMpdKsuIG5B3oWU/wQ0JkBhOmdVXMKwtxjYVcUrFRpNdNfwpkhHQYwGirQ== X-Received: by 2002:a17:902:da87:b0:215:9642:4d7a with SMTP id d9443c01a7336-21a83da6a40mr434425125ad.0.1736897165605; Tue, 14 Jan 2025 15:26:05 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21a7f1sm71225625ad.124.2025.01.14.15.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 15:26:05 -0800 (PST) Date: Tue, 14 Jan 2025 15:26:02 -0800 From: Joe Damato To: Daniel Sedlak Cc: Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Message-ID: Mail-Followup-To: Joe Damato , Daniel Sedlak , Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org References: <20250113131508.79c8511a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1736897165; x=1737501965; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=NV4PmVLk16CjHPkaMxzQZluPn2DMGP8myx2jLb4e+Pg=; b=q56lOCqDGe25GGvVk0Pzaz84lKdE6Fm34CKpAMldW8MkuOgFZzL6kXPtWkNtLaST/v Ysoabu/8HeIcXVI+rqVH9MvBD/4Jnd7U25P8JW3oOkoYSrpSbt7Vb1bWm60eLNphEJ2N 3GOV3k9WhBHehUEwMjVDs7NvVddzobdGg+FLI= X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=fastly.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=fastly.com header.i=@fastly.com header.a=rsa-sha256 header.s=google header.b=q56lOCqD Subject: Re: [Intel-wired-lan] [Question] Generic way to retrieve IRQ number of Tx/Rx queue X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jan 14, 2025 at 09:32:26AM +0100, Daniel Sedlak wrote: > > > On 1/13/25 10:15 PM, Jakub Kicinski wrote: > > > > We do have an API for that > > https://docs.kernel.org/next/networking/netlink_spec/netdev.html#napi > > but unfortunately the driver needs to support it, and i40e currently > > doesn't: > > Thank you for the link, I somehow missed that part of netlink... > > > $ git grep --files-with-matches netif_napi_set_irq > > drivers/net/ethernet/amazon/ena/ena_netdev.c > > drivers/net/ethernet/broadcom/bnxt/bnxt.c > > drivers/net/ethernet/broadcom/tg3.c > > drivers/net/ethernet/google/gve/gve_utils.c > > drivers/net/ethernet/intel/e1000/e1000_main.c > > drivers/net/ethernet/intel/e1000e/netdev.c > > drivers/net/ethernet/intel/ice/ice_lib.c > > drivers/net/ethernet/intel/igc/igc_main.c > > drivers/net/ethernet/mellanox/mlx4/en_cq.c > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c > > > > Should be easy to add. Let me CC the Intel list in case they already > > have a relevant change queued for i40e.. > > Thank you for directions, will check Intel's mailing list and poke around > with implementing that. I previously tried to add support for this API to i40e [1], but got pulled into other stuff and never picked it back up. Wanted to mention it in case it is useful for you. [1]: https://lore.kernel.org/lkml/20240410043936.206169-1-jdamato@fastly.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ADB72139D2 for ; Tue, 14 Jan 2025 23:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736897167; cv=none; b=DtNkshQbTrRNvUz7Qz9Jdw+gQdjtYJ7CJ8/qrj5loKVarg5izLYN038AO+16AvpjvdfJSZdEav7UBFxEHaEcZfcWHhYe5Xp0Fs23jX+v2eDDKEN56dB6PNSd0/5l/D3kiX8PHbcHlltrDNH7bfTEZoPvCsA4h6z7s3m/zPWiK7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736897167; c=relaxed/simple; bh=M/zA5myD7TcCfQp5oOilhju7M9SI5LbUs6P30WBHxK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iQS7PxZ6O5nLO1Ri6+7D6OmwL8qpEgxUh2SpsBadDyWFobXLhIF5cAJ+FoFw7v3RlaKoy/4b/rdB5SLJU8qK/HbBP0wBndLV2PsdQUL1l1YLEaexN70w6jtptVld1lGFCYTL9+RtvLocbizWzldJtcdle6gZpJDapXvkMUqL+Hc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=nZayV3xB; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="nZayV3xB" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2166f1e589cso130332235ad.3 for ; Tue, 14 Jan 2025 15:26:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1736897165; x=1737501965; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=NV4PmVLk16CjHPkaMxzQZluPn2DMGP8myx2jLb4e+Pg=; b=nZayV3xBwQ2gIMwoZXpS8KOs/Y7VgcZn7BL6Tlj9Uy/1J2vH4XNvFgKEXMXpTmKx5O 8rycF5UxSE+KSwrkgDxQu7hxNAWoDM+5EUW+JD8cw30L9cRFl7SJcpsHLyFu8OiOURHe M/BqM+f8QmhfypSSteSuvtcsxgCefShNoOwdQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736897165; x=1737501965; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NV4PmVLk16CjHPkaMxzQZluPn2DMGP8myx2jLb4e+Pg=; b=Je0x6riMwkYPHDO6ZzXYdR/C2R/XoiitnGKAmNO24AW3MPupO9xg7oSr/QDXGuJsnf hulpFQFcv+N1dwR7+CNGcL+eTCuPUAMWfslzNnX+aAre96MAgYg6hoRncEW73VUXyoaf kJpKhaBtC5PFsMt5202wYgI+ic0IFueBquGm7m46cWEXEj0QXM3b4Oz/F2m/kmNncfPT v6x47rB4owjk/kN9Aj9FF+TflL6oQNvIxpthWTfZPIw180c20KHKR9BS+3/viLoXJgpC 4Ljkzyi/DbvQkjLibwC05ViYBSewHt1HlBigyr9AFvF4/MxJQOyZvB1TLsxLhJwQ3Ej0 DsMw== X-Forwarded-Encrypted: i=1; AJvYcCUKihMdLVzv8ww29LEkVuZCftLMZzt5PJYeodEplblLQRSY9vwDjdHPcWTaj2fbqkWB3VEx4Ok=@vger.kernel.org X-Gm-Message-State: AOJu0Yz43EGWdMTm7h2WQHKxORwcm6W632OH1c+1UISjO3TUprz1t2oR 61mlGn2WNjifxASG/FWwTlPYjV8rCFFafgap0kbl9ArRXVhh7+VrxQP5fuKxs00= X-Gm-Gg: ASbGncuDAwpFDefQGNWbdMSqpE0p53fEFjSVIpLopI6D20+cSY48j3pGKl/yLCV8GAr xfzpPEu4R/ixtdqglahL2g3DbEBnR2Az6BWp5OB2iT+AOWvVYqQe1KiLYuuiaA14jXXU32wG1Re 8rsh0Aw2yYDV8WSLlXeHy43yOryX0hghcR4d0gOyb6ztROqan0Lh+D/n7pkIXuk+ceT5rnDD9t4 i4D9+ENs2m5W/6rkfVFCpX19hSklHwtXrj6EJpHAW8Uvhc/oK1/Mropy5NRjj+oXmkb3c+S7ZrB 05vPBVG9MAcwfpccMAtKunY= X-Google-Smtp-Source: AGHT+IHFPFr5ciMlkXuJKMpdKsuIG5B3oWU/wQ0JkBhOmdVXMKwtxjYVcUrFRpNdNfwpkhHQYwGirQ== X-Received: by 2002:a17:902:da87:b0:215:9642:4d7a with SMTP id d9443c01a7336-21a83da6a40mr434425125ad.0.1736897165605; Tue, 14 Jan 2025 15:26:05 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21a7f1sm71225625ad.124.2025.01.14.15.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 15:26:05 -0800 (PST) Date: Tue, 14 Jan 2025 15:26:02 -0800 From: Joe Damato To: Daniel Sedlak Cc: Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [Question] Generic way to retrieve IRQ number of Tx/Rx queue Message-ID: Mail-Followup-To: Joe Damato , Daniel Sedlak , Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org References: <20250113131508.79c8511a@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: On Tue, Jan 14, 2025 at 09:32:26AM +0100, Daniel Sedlak wrote: > > > On 1/13/25 10:15 PM, Jakub Kicinski wrote: > > > > We do have an API for that > > https://docs.kernel.org/next/networking/netlink_spec/netdev.html#napi > > but unfortunately the driver needs to support it, and i40e currently > > doesn't: > > Thank you for the link, I somehow missed that part of netlink... > > > $ git grep --files-with-matches netif_napi_set_irq > > drivers/net/ethernet/amazon/ena/ena_netdev.c > > drivers/net/ethernet/broadcom/bnxt/bnxt.c > > drivers/net/ethernet/broadcom/tg3.c > > drivers/net/ethernet/google/gve/gve_utils.c > > drivers/net/ethernet/intel/e1000/e1000_main.c > > drivers/net/ethernet/intel/e1000e/netdev.c > > drivers/net/ethernet/intel/ice/ice_lib.c > > drivers/net/ethernet/intel/igc/igc_main.c > > drivers/net/ethernet/mellanox/mlx4/en_cq.c > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c > > > > Should be easy to add. Let me CC the Intel list in case they already > > have a relevant change queued for i40e.. > > Thank you for directions, will check Intel's mailing list and poke around > with implementing that. I previously tried to add support for this API to i40e [1], but got pulled into other stuff and never picked it back up. Wanted to mention it in case it is useful for you. [1]: https://lore.kernel.org/lkml/20240410043936.206169-1-jdamato@fastly.com/