From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Doug Goldstein <cardoe@cardoe.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: Re: [PATCH for-4.20] automation/gitlab: disable coverage from clang randconfig
Date: Wed, 15 Jan 2025 09:17:11 +0100 [thread overview]
Message-ID: <Z4dvBxuB9gl-Y_yL@macbook.local> (raw)
In-Reply-To: <c715348e-0f40-4ac4-b38e-1aead29cde52@citrix.com>
On Tue, Jan 14, 2025 at 05:48:20PM +0000, Andrew Cooper wrote:
> On 14/01/2025 5:43 pm, Roger Pau Monne wrote:
> > If randconfig enables coverage support the build times out due to GNU LD
> > taking too long. For the time being prevent coverage from being enabled in
> > clang randconfig job.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thanks.
> > ---
> > Cc: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> > I will fix the orphaned section stuff separately, as I'm considering just
> > removing LLVM coverage support because the llvm coverage format is not
> > stable, and the code to dump it has already become stale. However I need
> > to think about it, and in the short term disabling coverage support from
> > randconfig is more straightforward.
>
> Oh, so it's broken too? Unless the fix is trivial, we should have a
> Kconfig level disable on it. No point letting people turn on something
> that's broken.
It's not build time broken, but the format of the buffer that we
return in llvm.c dump() function has gotten out of sync with the
native format in modern clang versions, and hence coverage tools will
refuse to parse it.
I think newer versions of llvm/clang have now included an internal
function to dump the buffer, so that we no longer have to attempt to
generate it from Xen, I need to see whether that works. Otherwise the
only remaining option is to convert the llvm data into gcov format
(which is stable), IIRC this is what Linux did.
Thanks, Roger.
next prev parent reply other threads:[~2025-01-15 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 17:43 [PATCH for-4.20] automation/gitlab: disable coverage from clang randconfig Roger Pau Monne
2025-01-14 17:48 ` Andrew Cooper
2025-01-14 23:49 ` Stefano Stabellini
2025-01-15 8:17 ` Roger Pau Monné [this message]
2025-01-15 8:19 ` Jan Beulich
2025-01-15 8:34 ` Andrew Cooper
2025-01-15 8:56 ` Roger Pau Monné
2025-01-15 9:35 ` Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4dvBxuB9gl-Y_yL@macbook.local \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.