From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8EC1EEA20 for ; Wed, 15 Jan 2025 10:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736937101; cv=none; b=uXgKbLdcq40m0tx0BDAYKhNJtWxH+gJx0JeEaEJAXEmDswPsXuv0ck7sgdf6Bzs9OQ0oQ970BVm2i+7xiBGYYKiprtYwB5vVYAf4YvoxXmIDx53MqDjT7UAvUbuKLsfs4VVdXoriuCgp9MZCEbr3EQhBNXliC37h9sot4QlGUZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736937101; c=relaxed/simple; bh=nAM87dSI/bjYG1LX+vgVU00niVK8imgoXT3cwHO91G4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UQaKpPVM2W+gmiGsFpGW5+1TU54+flBWytvLFXKJ8fErswfRx9vfmDhWlZuwe1sg/YDWEKA0DljQeJ1k5Jn0G8sR1Qq1MZ+PzW2t0MCmuO55ChrG+nPzWRTlWviBjZXpOo6/fVn/UbVczyX1FlfCMXduUYg9/UXbNo3bmQmB6oE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SyADEZao; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SyADEZao" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43675b1155bso73990405e9.2 for ; Wed, 15 Jan 2025 02:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736937097; x=1737541897; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h2IhNICG//WBQQl7qLkp5tsyWXLzU3tzMqcugbJYX9Q=; b=SyADEZao60YgAD/KtuA0WcRQQDTDwQfi9QFz8u1OxderbnBCK2GdlQRWOb2bUax+kv wq/1tQgAZA8whKOo2/CpxfrebM0cltL6s5S0GqPbmVvbZWJN3CSoD3S5qbX72slE6qVT 1h7kBsZ64mXDIoqAljYmK2R8GPvXyVMTWdIiRWaRJo07BYfDRNU5cbmN22S7aiPbOrMN kVDZlH3eW1Nm5L724BYp/mGa2Fu4gaKirnciLKjMojzV4NjXbzj8oSiYv8h66A0DVTN1 WFpO94k8KUQrxVPmnU8k31xhSTI3ywxCIIFYbC18bW4zDZ5MFhZS0NoFIpKhWV/Zbu2m Sr8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736937097; x=1737541897; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h2IhNICG//WBQQl7qLkp5tsyWXLzU3tzMqcugbJYX9Q=; b=IB5EHiYK4dZos+dmegMtGAo3FAQQa7w9Hdt0n93NSHEzPhMpklPh0eCYz/a0NByGto 1X06jqDBFkGUTMNxbLHZuBPuEIjyea6UMVb3L1kCjq+BdRvuV8Se1GfURUDQSiq/nobX DLwiOW/bFCQ7wZHpEDPpFzji2CuQCfQClAsv53sFwcIgw2NJt0dD7WBp3fNFCdYCdOya qekD3GHZG2wvHV8mj5zrj6apsbcc4QLa6xRZW0Rc4uGumBgTBW26cYB6he0PWZd1xCUr W886s1uoKm51AsVKtriocpE4p08rYbkJgxPYMmjZlh1aDRgCSAXLOophpGIn/1iyb7DC bosg== X-Forwarded-Encrypted: i=1; AJvYcCWzPCoyvmSI/4btiSBhy5V+W1rlii033pnnB43P2kr7kodCZlj2t82GlyfD5D5Zx7LhIXnq5c6w8HWvbF4=@vger.kernel.org X-Gm-Message-State: AOJu0YwWN0VcQGMUUnoTDWM+SlgDhSl4l6EG0u5rdNAHWjLWWRkbP9ry AAG/fCUusQuy5baUjAJwnGKba9MPO5KJaOCO2N4WNKgvyYU1D+zFp+pg9AaHuYE= X-Gm-Gg: ASbGncu3NgRlrG+IRHXPDm8/sClgSaKWBS7Odo6ngZA+XHCsbnrWY9NMKg1CHdG9MqY UI1MUCS/c1xPh7zs/RfOeFYAPMd7YVgj245qtijHJLgGet0hH2bGpT2CCXTgs8FQdkXejHYtIJB a6ERRMKQvrT9Whf8kT4XT/ejQK9JoblhydR2Q1/320fN4RIYk72xYwdPwsBc4hlGQBu/s9mAm4R PpER9TX+0pHpaZ1divx4p64XXpzkcL4XiPU+31kCgnaGhU6H68SPRlj8g== X-Google-Smtp-Source: AGHT+IHe1nk1tmVphuzNweFa7LBugWSjV0w6H9pAl/JfNhlVB1fSBUgZxw9EmcU1525zsv2eGVgEoA== X-Received: by 2002:a05:600c:3ba0:b0:434:a802:43d with SMTP id 5b1f17b1804b1-436e27170c7mr232712275e9.27.1736937094745; Wed, 15 Jan 2025 02:31:34 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74ab250sm18254785e9.9.2025.01.15.02.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 02:31:34 -0800 (PST) Date: Wed, 15 Jan 2025 11:31:32 +0100 From: Petr Mladek To: Joel Granados Cc: Chris Down , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sergey Senozhatsky , Steven Rostedt , John Ogness , Geert Uytterhoeven , Tony Lindgren , kernel-team@fb.com Subject: Re: [PATCH v6 06/11] printk: console: Introduce sysfs interface for per-console loglevels Message-ID: References: <0312cd1e80e68a1450a194ebce27728cdf497575.1730133890.git.chris@chrisdown.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri 2025-01-10 11:27:53, Joel Granados wrote: > On Mon, Oct 28, 2024 at 04:45:46PM +0000, Chris Down wrote: > > A sysfs interface under /sys/class/console/ is created that permits > > viewing and configuring per-console attributes. This is the main > > interface with which we expect users to interact with and configure > > per-console loglevels. > These are different from the knobs that you added to sysctl. right? The > ones in sysctl are general values as opposed to console specific. > > Would it make sense to put everything in here (sys) instead of having > them separate? I thought about this as well. It would be nice to have the setting in one place. But I am afraid that it can't be done easily. I think that I looked this variant and did not find a way how to do it with the existing API around struct device, /sys/class, ... That said, I am not familiar with the API. It is quite possible that I just missed it. One advantage of the /proc/sys/ is that the values might be modified using the sysctl tool. It might be easier than searching the maze of directories under /sys. And the global values might be enough for most users. Best Regards, Petr PS: AFAIK, Chris is going to send an updated version of this patchset. He postponed it until the per-console kthreads were introduced...