From: Ido Schimmel <idosch@nvidia.com>
To: Guillaume Nault <gnault@redhat.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH net-next] ipv4: Prepare inet_rtm_getroute() to .flowi4_tos conversion.
Date: Wed, 15 Jan 2025 18:40:50 +0200 [thread overview]
Message-ID: <Z4flEv2n52lxrTED@shredder> (raw)
In-Reply-To: <7bc1c7dc47ad1393569095d334521fae59af5bc7.1736944951.git.gnault@redhat.com>
On Wed, Jan 15, 2025 at 01:44:52PM +0100, Guillaume Nault wrote:
> Store rtm->rtm_tos in a dscp_t variable, which can then be used for
> setting fl4.flowi4_tos and also be passed as parameter of
> ip_route_input_rcu().
>
> The .flowi4_tos field is going to be converted to dscp_t to ensure ECN
> bits aren't erroneously taken into account during route lookups. Having
> a dscp_t variable available will simplify that conversion, as we'll
> just have to drop the inet_dscp_to_dsfield() call.
>
> Note that we can't just convert rtm->rtm_tos to dscp_t because this
> structure is exported to user space.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-01-15 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 12:44 [PATCH net-next] ipv4: Prepare inet_rtm_getroute() to .flowi4_tos conversion Guillaume Nault
2025-01-15 16:40 ` Ido Schimmel [this message]
2025-01-17 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4flEv2n52lxrTED@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.