All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasilis Liaskovitis <vliaskovitis@suse.com>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: Vasilis Liaskovitis <vliaskovitis@suse.com>,
	qemu-devel@nongnu.org, qemu-riscv@nongnu.org, palmer@dabbelt.com,
	alistair.francis@wdc.com, jason.chien@sifive.com,
	zhiwei_liu@linux.alibaba.com, dbarboza@ventanamicro.com,
	bmeng.cn@gmail.com, liwei1518@gmail.com, philmd@linaro.org
Subject: Re: [RFC PATCH] hw/riscv/virt: Add serial alias in DTB
Date: Thu, 16 Jan 2025 14:38:21 +0100	[thread overview]
Message-ID: <Z4kLze26LZNqqiU3@linux-bfvj> (raw)
In-Reply-To: <20250116-089f795c1302e6f2b4a6b8c0@orel>

On Thu, Jan 16, 2025 at 10:23:56AM +0100, Andrew Jones wrote:
> 
> s/Fixes/Resolves/ (see docs/devel/submitting-a-patch.rst)
> 
[..]
> >      qemu_fdt_setprop_string(ms->fdt, "/chosen", "stdout-path", name);
> > +    qemu_fdt_add_subnode(ms->fdt, "/aliases");
> 
> create_fdt_uart() is called at machine-done time, so we should create the
> /aliases node in create_fdt() in case we ever have other uses for it.

thanks for the review, I am sending a v2 with the changes.

- Vasilis


      reply	other threads:[~2025-01-16 13:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16  8:46 [RFC PATCH] hw/riscv/virt: Add serial alias in DTB Vasilis Liaskovitis
2025-01-16  9:23 ` Andrew Jones
2025-01-16 13:38   ` Vasilis Liaskovitis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4kLze26LZNqqiU3@linux-bfvj \
    --to=vliaskovitis@suse.com \
    --cc=ajones@ventanamicro.com \
    --cc=alistair.francis@wdc.com \
    --cc=bmeng.cn@gmail.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=jason.chien@sifive.com \
    --cc=liwei1518@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.