From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: testunit: on errors, repeat NACK until STOP
Date: Thu, 16 Jan 2025 18:20:44 +0100 [thread overview]
Message-ID: <Z4k_7A5AFISEu2eI@shikoro> (raw)
In-Reply-To: <20250115184609.1844-2-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On Wed, Jan 15, 2025 at 07:45:52PM +0100, Wolfram Sang wrote:
> This backend requests a NACK from the controller driver when it detects
> an error. If that request gets ignored from some reason, subsequent
> accesses will wrongly be handled OK. To fix this, an error now changes
> the state machine, so the backend will report NACK until a STOP
> condition has been detected. This make the driver more robust against
> controllers which will sadly apply the NACK not to the current byte but
> the next one.
>
> Fixes: a8335c64c5f0 ("i2c: add slave testunit driver")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-01-16 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 18:45 [PATCH] i2c: testunit: on errors, repeat NACK until STOP Wolfram Sang
2025-01-16 17:20 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4k_7A5AFISEu2eI@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.