All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"
Date: Thu, 16 Jan 2025 17:32:23 +0200	[thread overview]
Message-ID: <Z4kmh6YHkNUGFnMK@smile.fi.intel.com> (raw)
In-Reply-To: <2025011605-splashed-giddy-0289@gregkh>

On Thu, Jan 16, 2025 at 04:24:16PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Jan 16, 2025 at 05:21:51PM +0200, Andy Shevchenko wrote:

...

> >  #ifdef CONFIG_PM
> >  #define _EXPORT_DEV_PM_OPS(name, license, ns)		_EXPORT_PM_OPS(name, license, ns)
> > -#define EXPORT_PM_FN_GPL(name)				EXPORT_SYMBOL_GPL(name)
> > -#define EXPORT_PM_FN_NS_GPL(name, ns)			EXPORT_SYMBOL_NS_GPL(name, "ns")
> >  #else
> >  #define _EXPORT_DEV_PM_OPS(name, license, ns)		_DISCARD_PM_OPS(name, license, ns)
> > -#define EXPORT_PM_FN_GPL(name)
> > -#define EXPORT_PM_FN_NS_GPL(name, ns)
> 
> Why not start using them instead?

I tried and they didn't produce what we want (code elimination for
the CONFIG_PM=n).

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-01-16 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 15:21 [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions" Andy Shevchenko
2025-01-16 15:24 ` Greg Kroah-Hartman
2025-01-16 15:32   ` Andy Shevchenko [this message]
2025-01-16 15:39     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4kmh6YHkNUGFnMK@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.