From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: kw@linux.com, gregkh@linuxfoundation.org, arnd@arndb.de,
lpieralisi@kernel.org, shuah@kernel.org, kishon@kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, linux-arm-msm@vger.kernel.org,
robh@kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 3/4] selftests: Move PCI Endpoint tests from tools/pci to Kselftests
Date: Thu, 16 Jan 2025 16:39:47 +0100 [thread overview]
Message-ID: <Z4koQ7zoePf2_hPu@ryzen> (raw)
In-Reply-To: <20250116135106.19143-4-manivannan.sadhasivam@linaro.org>
On Thu, Jan 16, 2025 at 07:21:05PM +0530, Manivannan Sadhasivam wrote:
> This just moves the existing tests under tools/pci to
> tools/testing/selftests/pci_endpoint and adjusts the paths in Makefile
> accordingly. Migration to Kselftest framework will be done in subsequent
> commits.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/PCI/endpoint/pci-test-howto.rst | 9 +++++----
> MAINTAINERS | 2 +-
> tools/testing/selftests/pci_endpoint/.gitignore | 3 +++
> tools/{pci => testing/selftests/pci_endpoint}/Build | 0
> tools/{pci => testing/selftests/pci_endpoint}/Makefile | 10 +++++-----
> .../{pci => testing/selftests/pci_endpoint}/pcitest.c | 0
> .../{pci => testing/selftests/pci_endpoint}/pcitest.sh | 0
> 7 files changed, 14 insertions(+), 10 deletions(-)
> create mode 100644 tools/testing/selftests/pci_endpoint/.gitignore
> rename tools/{pci => testing/selftests/pci_endpoint}/Build (100%)
> rename tools/{pci => testing/selftests/pci_endpoint}/Makefile (83%)
> rename tools/{pci => testing/selftests/pci_endpoint}/pcitest.c (100%)
> rename tools/{pci => testing/selftests/pci_endpoint}/pcitest.sh (100%)
>
> diff --git a/Documentation/PCI/endpoint/pci-test-howto.rst b/Documentation/PCI/endpoint/pci-test-howto.rst
> index 909f770a07d6..c4ae7af50ede 100644
> --- a/Documentation/PCI/endpoint/pci-test-howto.rst
> +++ b/Documentation/PCI/endpoint/pci-test-howto.rst
> @@ -123,16 +123,17 @@ above::
> Using Endpoint Test function Device
> -----------------------------------
>
> -pcitest.sh added in tools/pci/ can be used to run all the default PCI endpoint
> -tests. To compile this tool the following commands should be used::
> +pcitest.sh added in tools/testing/selftests/pci_endpoint can be used to run all
> +the default PCI endpoint tests. To compile this tool the following commands
> +should be used::
>
> # cd <kernel-dir>
> - # make -C tools/pci
> + # make -C tools/testing/selftests/pci_endpoint
>
> or if you desire to compile and install in your system::
>
> # cd <kernel-dir>
> - # make -C tools/pci install
> + # make -C tools/testing/selftests/pci_endpoint install
>
> The tool and script will be located in <rootfs>/usr/bin/
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e0fcdd8b6434..e96e80d8486d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18002,7 +18002,7 @@ F: Documentation/PCI/endpoint/*
> F: Documentation/misc-devices/pci-endpoint-test.rst
> F: drivers/misc/pci_endpoint_test.c
> F: drivers/pci/endpoint/
> -F: tools/pci/
> +F: tools/testing/selftests/pci_endpoint/
>
> PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
> M: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
> diff --git a/tools/testing/selftests/pci_endpoint/.gitignore b/tools/testing/selftests/pci_endpoint/.gitignore
> new file mode 100644
> index 000000000000..29ab47c48484
> --- /dev/null
> +++ b/tools/testing/selftests/pci_endpoint/.gitignore
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +*.o
> +pcitest
> diff --git a/tools/pci/Build b/tools/testing/selftests/pci_endpoint/Build
> similarity index 100%
> rename from tools/pci/Build
> rename to tools/testing/selftests/pci_endpoint/Build
> diff --git a/tools/pci/Makefile b/tools/testing/selftests/pci_endpoint/Makefile
> similarity index 83%
> rename from tools/pci/Makefile
> rename to tools/testing/selftests/pci_endpoint/Makefile
> index 62d41f1a1e2c..3c6fe18e32cc 100644
> --- a/tools/pci/Makefile
> +++ b/tools/testing/selftests/pci_endpoint/Makefile
> @@ -1,11 +1,10 @@
> # SPDX-License-Identifier: GPL-2.0
> -include ../scripts/Makefile.include
> +include ../../../scripts/Makefile.include
>
> bindir ?= /usr/bin
>
> ifeq ($(srctree),)
> -srctree := $(patsubst %/,%,$(dir $(CURDIR)))
> -srctree := $(patsubst %/,%,$(dir $(srctree)))
> +srctree := $(patsubst %/tools/testing/selftests/,%,$(dir $(CURDIR)))
> endif
>
> # Do not use make's built-in rules
> @@ -27,10 +26,11 @@ include $(srctree)/tools/build/Makefile.include
> #
> # We need the following to be outside of kernel tree
> #
> -$(OUTPUT)include/linux/: ../../include/uapi/linux/
> +$(OUTPUT)include/linux/: ../../../../include/uapi/linux/
> mkdir -p $(OUTPUT)include/linux/ 2>&1 || true
> - ln -sf $(CURDIR)/../../include/uapi/linux/pcitest.h $@
> + ln -sf $(CURDIR)/../../../../include/uapi/linux/pcitest.h $@
>
> +$(info ${CURDIR})
> prepare: $(OUTPUT)include/linux/
>
> PCITEST_IN := $(OUTPUT)pcitest-in.o
> diff --git a/tools/pci/pcitest.c b/tools/testing/selftests/pci_endpoint/pcitest.c
> similarity index 100%
> rename from tools/pci/pcitest.c
> rename to tools/testing/selftests/pci_endpoint/pcitest.c
> diff --git a/tools/pci/pcitest.sh b/tools/testing/selftests/pci_endpoint/pcitest.sh
> similarity index 100%
> rename from tools/pci/pcitest.sh
> rename to tools/testing/selftests/pci_endpoint/pcitest.sh
> --
> 2.25.1
>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-01-16 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 13:51 [PATCH v5 0/4] Migrate PCI Endpoint Subsystem tests to Kselftest Manivannan Sadhasivam
2025-01-16 13:51 ` [PATCH v5 1/4] PCI: endpoint: pci-epf-test: Fix the check for DMA MEMCPY test Manivannan Sadhasivam
2025-01-16 15:10 ` Niklas Cassel
2025-01-16 13:51 ` [PATCH v5 2/4] misc: pci_endpoint_test: Fix the return value of IOCTL Manivannan Sadhasivam
2025-01-16 13:51 ` [PATCH v5 3/4] selftests: Move PCI Endpoint tests from tools/pci to Kselftests Manivannan Sadhasivam
2025-01-16 15:39 ` Niklas Cassel [this message]
2025-01-16 13:51 ` [PATCH v5 4/4] selftests: pci_endpoint: Migrate to Kselftest framework Manivannan Sadhasivam
2025-01-16 15:39 ` Niklas Cassel
2025-01-16 15:36 ` [PATCH v5 0/4] Migrate PCI Endpoint Subsystem tests to Kselftest Niklas Cassel
2025-01-16 16:12 ` Manivannan Sadhasivam
2025-01-16 16:39 ` Niklas Cassel
2025-01-16 17:10 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4koQ7zoePf2_hPu@ryzen \
--to=cassel@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.