From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Kyle Evans <kevans@freebsd.org>,
Hanna Reitz <hreitz@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Warner Losh <imp@bsdimp.com>, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, armbru@redhat.com,
Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: Re: [PATCH v2] qemu/compiler: Absorb 'clang-tsa.h'
Date: Fri, 17 Jan 2025 12:24:31 +0100 [thread overview]
Message-ID: <Z4o9738w_9vNjVal@redhat.com> (raw)
In-Reply-To: <20250116211111.53961-1-philmd@linaro.org>
Am 16.01.2025 um 22:11 hat Philippe Mathieu-Daudé geschrieben:
> We already have "qemu/compiler.h" for compiler-specific arrangements,
> automatically included by "qemu/osdep.h" for each source file. No
> need to explicitly include a header for a Clang particularity,
> let the common "qemu/compiler.h" deal with that by having it
> include "qemu/clang-tsa.h" (renamed as qemu/clang-tsa.h.inc).
> Add a check to not include "qemu/clang-tsa.h.inc" directly,
> remove previous "qemu/clang-tsa.h" inclusions.
>
> Suggested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Don't we normally try to reduce the number of header files that need to
be opened during the build instead of increasing it?
Either way, if we do want to do this, the implementation looks correct.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2025-01-17 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 21:11 [PATCH v2] qemu/compiler: Absorb 'clang-tsa.h' Philippe Mathieu-Daudé
2025-01-17 1:59 ` Pierrick Bouvier
2025-01-17 10:39 ` Alex Bennée
2025-01-17 11:24 ` Kevin Wolf [this message]
2025-01-17 16:26 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4o9738w_9vNjVal@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=hreitz@redhat.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.