From: Pranjal Shrivastava <praan@google.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
jgg@ziepe.ca, nicolinc@nvidia.com, mshavit@google.com,
smostafa@google.com, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH] iommu/arm-smmu-v3: Include string_choices.h header for str_read_write
Date: Fri, 17 Jan 2025 08:34:20 +0000 [thread overview]
Message-ID: <Z4oWDGaXpY-PPkqr@google.com> (raw)
In-Reply-To: <20250116121025.118464-1-angelogioacchino.delregno@collabora.com>
On Thu, Jan 16, 2025 at 01:10:25PM +0100, AngeloGioacchino Del Regno wrote:
> The str_read_write() helper function is defined in the missing
> string_choices.h header: include it to resolve build failures.
>
> Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> index 0e4cbb2c64d7..a0e395da8a88 100644
> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> @@ -26,6 +26,7 @@
> #include <linux/pci.h>
> #include <linux/pci-ats.h>
> #include <linux/platform_device.h>
> +#include <linux/string_choices.h>
> #include <kunit/visibility.h>
> #include <uapi/linux/iommufd.h>
>
Hi Angelo,
This change has been applied to the arm/smmu/updates branch and should
be available in the -next when the maintainers rebuild the branch.
Thanks,
Praan
prev parent reply other threads:[~2025-01-17 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 12:10 [PATCH] iommu/arm-smmu-v3: Include string_choices.h header for str_read_write AngeloGioacchino Del Regno
2025-01-17 8:34 ` Pranjal Shrivastava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4oWDGaXpY-PPkqr@google.com \
--to=praan@google.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.