From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, devel@daynix.com,
Lei Yang <leiyang@redhat.com>
Subject: Re: [PATCH v4 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()
Date: Fri, 17 Jan 2025 13:08:12 +0000 [thread overview]
Message-ID: <Z4pWPDReumYvqcE4@redhat.com> (raw)
In-Reply-To: <20250115-glib-v4-2-a827b2676259@daynix.com>
On Wed, Jan 15, 2025 at 09:03:08PM +0900, Akihiko Odaki wrote:
> g_spawn_sync() (for GLib < 2.68) or g_spawn_async_with_pipes_and_fds()
> (for the newer) gives an informative message if it fails to execute
> the script instead of reporting exiting status 1.
>
> g_spawn_check_wait_status() also gives an message easier to understand
> than the raw value returned by waitpid().
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> Tested-by: Lei Yang <leiyang@redhat.com>
> ---
> net/tap.c | 220 +++++++++++++++++++++++++++++++++-----------------------------
> 1 file changed, 117 insertions(+), 103 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2025-01-17 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 12:03 [PATCH v4 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status() Akihiko Odaki
2025-01-15 12:03 ` [PATCH v4 1/2] glib-compat: Define g_spawn_check_wait_status() Akihiko Odaki
2025-01-17 13:07 ` Daniel P. Berrangé
2025-01-15 12:03 ` [PATCH v4 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status() Akihiko Odaki
2025-01-17 13:08 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4pWPDReumYvqcE4@redhat.com \
--to=berrange@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=devel@daynix.com \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.