Re: [PATCH v3 08/11] Input: xpad - add support for Nacon Evol-X Xbox One Controller

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Pavel,

On Tue, Jan 07, 2025 at 08:28:27PM +0100, Pavel Rojtberg wrote:
> From: Matheos Mattsson <matheos.mattsson@gmail.com>
> 
> Signed-off-by: Matheos Mattsson <matheos.mattsson@gmail.com>

I checked several patches against the github repository and in github
there are no "Signed-off-by"s from the original authors. I understand
and fully appreciate the desire to credit the original authors, but you
can not add SOBs on their behalf.

I think the best way would be to combine all the changes into one patch
authored by you and give credit to all the people involved in the commit
description.

> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
> ---
>  drivers/input/joystick/xpad.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 237704b3fab5..18e33e2aeaa7 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -394,6 +394,7 @@ static const struct xpad_device {
>  	{ 0x3285, 0x0607, "Nacon GC-100", 0, XTYPE_XBOX360 },
>  	{ 0x3285, 0x0614, "Nacon Pro Compact", 0, XTYPE_XBOXONE },
>  	{ 0x3285, 0x0662, "Nacon Revolution5 Pro", 0, XTYPE_XBOX360 },
> +	{ 0x3285, 0x0663, "Nacon Evol-X", 0, XTYPE_XBOXONE },
>  	{ 0x3537, 0x1004, "GameSir T4 Kaleid", 0, XTYPE_XBOX360 },
>  	{ 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0, XTYPE_XBOX },
>  	{ 0x413d, 0x2104, "Black Shark Green Ghost Gamepad", 0, XTYPE_XBOX360 },
> @@ -543,6 +544,7 @@ static const struct usb_device_id xpad_table[] = {
>  	XPAD_XBOXONE_VENDOR(0x2e95),		/* SCUF Gaming Controller */
>  	XPAD_XBOX360_VENDOR(0x31e3),		/* Wooting Keyboards */
>  	XPAD_XBOX360_VENDOR(0x3285),		/* Nacon GC-100 */
> +	XPAD_XBOXONE_VENDOR(0x3285),		/* Nacon Evol-X */
>  	XPAD_XBOX360_VENDOR(0x3537),		/* GameSir Controllers */
>  	XPAD_XBOXONE_VENDOR(0x3537),		/* GameSir Controllers */
>  	XPAD_XBOX360_VENDOR(0x413d),		/* Black Shark Green Ghost Controller */
> -- 
> 2.43.0
> 

Thanks.

-- 
Dmitry