All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Chun-Tse Shao <ctshao@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	irogers@google.com, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [PATCH v4 0/5] Tracing contention lock owner call stack
Date: Fri, 31 Jan 2025 14:51:18 -0800	[thread overview]
Message-ID: <Z51T5tNkGGbiXZCi@google.com> (raw)
In-Reply-To: <20250130052510.860318-1-ctshao@google.com>

Hello,

On Wed, Jan 29, 2025 at 09:21:34PM -0800, Chun-Tse Shao wrote:
> 
> v4: Edit based on Namhyung's review.
> 
> v3: Edit based on Namhyung's review.
> 
> v2: Fix logic deficit in patch 2/4.

This change log doesn't give any meaningful info.  You'd better say what
exactly you changed.

Thanks,
Namhyung

> 
> Chun-Tse Shao (5):
>   perf lock: Add bpf maps for owner stack tracing
>   perf lock: Retrieve owner callstack in bpf program
>   perf lock: Make rb_tree helper functions generic
>   perf lock: Report owner stack in usermode
>   perf lock: Update documentation for -o option in contention mode
> 
>  tools/perf/builtin-lock.c                     |  59 +++-
>  tools/perf/util/bpf_lock_contention.c         |  68 ++++-
>  .../perf/util/bpf_skel/lock_contention.bpf.c  | 281 +++++++++++++++++-
>  tools/perf/util/bpf_skel/lock_data.h          |   7 +
>  tools/perf/util/lock-contention.h             |   7 +
>  5 files changed, 405 insertions(+), 17 deletions(-)
> 
> --
> 2.48.1.362.g079036d154-goog
> 

      parent reply	other threads:[~2025-01-31 22:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  5:21 [PATCH v4 0/5] Tracing contention lock owner call stack Chun-Tse Shao
2025-01-30  5:21 ` [PATCH v4 1/5] perf lock: Add bpf maps for owner stack tracing Chun-Tse Shao
2025-01-30  5:21 ` [PATCH v4 2/5] perf lock: Retrieve owner callstack in bpf program Chun-Tse Shao
2025-01-31 23:48   ` Namhyung Kim
2025-02-11 23:26     ` Chun-Tse Shao
2025-02-12  1:45       ` Namhyung Kim
2025-01-30  5:21 ` [PATCH v4 3/5] perf lock: Make rb_tree helper functions generic Chun-Tse Shao
2025-01-30  5:21 ` [PATCH v4 4/5] perf lock: Report owner stack in usermode Chun-Tse Shao
2025-01-30  5:21 ` [PATCH v4 5/5] perf lock: Update documentation for -o option in contention mode Chun-Tse Shao
2025-01-31 22:51 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z51T5tNkGGbiXZCi@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=ctshao@google.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.