From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Heimir Thor Sverrisson <heimir.sverrisson@gmail.com>,
hao.yao@intel.com, mchehab@kernel.org,
linux-media@vger.kernel.org, hdegoede@redhat.com,
joachim.reichel@posteo.de,
Ingvar Hagelund <ingvar@redpill-linpro.com>
Subject: Re: [PATCH v7] media: i2c: Add Omnivision OV02C10 sensor driver
Date: Wed, 22 Jan 2025 10:18:03 +0100 [thread overview]
Message-ID: <Z5C3y5e7wCo9Gujt@linux.intel.com> (raw)
In-Reply-To: <Z5CtMaPUlNs8xhBa@kekkonen.localdomain>
Hi
On Wed, Jan 22, 2025 at 08:32:49AM +0000, Sakari Ailus wrote:
> > + /* Check HW config */
> > + ret = ov02c10_check_hwcfg(&client->dev, ov02c10);
> > + if (ret) {
> > + dev_err(&client->dev, "failed to check hwcfg: %d", ret);
> > + return ret;
> > + }
> > +
> > + v4l2_i2c_subdev_init(&ov02c10->sd, client, &ov02c10_subdev_ops);
> > + ov02c10_get_pm_resources(&client->dev);
>
> Error handling is missing.
It is fine since we can work without pm/gpio's on setups where iVSC
control powering of the sensor. Maybe comment about that could be added.
Regards
Stanislaw
next prev parent reply other threads:[~2025-01-22 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 23:22 [PATCH v7] media: i2c: Add Omnivision OV02C10 sensor driver Heimir Thor Sverrisson
2025-01-22 8:32 ` Sakari Ailus
2025-01-22 9:18 ` Stanislaw Gruszka [this message]
2025-01-22 9:23 ` Sakari Ailus
2025-01-27 11:14 ` Hans de Goede
2025-01-22 9:36 ` Stanislaw Gruszka
2025-01-22 16:52 ` Stanislaw Gruszka
2025-03-11 17:32 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5C3y5e7wCo9Gujt@linux.intel.com \
--to=stanislaw.gruszka@linux.intel.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=heimir.sverrisson@gmail.com \
--cc=ingvar@redpill-linpro.com \
--cc=joachim.reichel@posteo.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.