From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D042C02181 for ; Wed, 22 Jan 2025 09:49:41 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.875844.1286255 (Exim 4.92) (envelope-from ) id 1taXMI-0002Re-Fm; Wed, 22 Jan 2025 09:49:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 875844.1286255; Wed, 22 Jan 2025 09:49:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1taXMI-0002RX-Cm; Wed, 22 Jan 2025 09:49:14 +0000 Received: by outflank-mailman (input) for mailman id 875844; Wed, 22 Jan 2025 09:49:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1taXMI-0002RR-24 for xen-devel@lists.xenproject.org; Wed, 22 Jan 2025 09:49:14 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22773307-d8a6-11ef-a0e5-8be0dac302b0; Wed, 22 Jan 2025 10:49:12 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-aaf57c2e0beso1301923166b.3 for ; Wed, 22 Jan 2025 01:49:12 -0800 (PST) Received: from localhost ([84.78.159.3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384c5c465sm891577866b.17.2025.01.22.01.49.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2025 01:49:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22773307-d8a6-11ef-a0e5-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1737539352; x=1738144152; darn=lists.xenproject.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EJSCDKb2eB5CRIvZDbmZLNEwqJEBlN0L6WqqdCi1C5s=; b=sTPp3GY1BMmiy13ZPqwr2hXKW2jLWxUJXTKDisjWN7xQI6sFxzhZGcTdNjihMNETBj aaUJ+FZuC0+vesOSR3sPf3L8/ruaZWOj7u/qOFwexlVirBvhBXBqHQJ9cQlkWDYLZQ4J +aCmaWjUxFbXZMOBLLfFHwshevg7+s7jVxfqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737539352; x=1738144152; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EJSCDKb2eB5CRIvZDbmZLNEwqJEBlN0L6WqqdCi1C5s=; b=MjHn885lPnvzd8l2bgPSp6KTf+uTZ550CaHN66PseJAjaSbckSxdaYumm1IKROYmJj Gd9mtVKWrEbY7wRa0/FluuL2Y1wwCncqhh5+m3JVbCjNwYuzppF7myTqsT3Fmjtn7pc/ uA2KsdGmJNZtu6jNemcsgHTQwqk4SsuJVMhbrr2bzwYUOhWP5AQLL4WryQkWCtPgRPq4 YDe8Pf4IcGs0ouXDL2ttU2Or0Uh0kq3zhWxaiTHyCrHcMv7y7C3ojZmg0N7B6XAMBMIJ CnSOWTKoQn+Md8JTyqVX+EgjK0QaWLNSjhK/m1QdRW9CAYSfwhLhlzCuF6DiMSFjB5TO 8whw== X-Forwarded-Encrypted: i=1; AJvYcCVJkfmfGTJAG8lzH6f4UgMrRKW+rh08hlP3aJRd3+TRPsFQTuV+JwaPAjjKtqakqDr488NLycDQIpk=@lists.xenproject.org X-Gm-Message-State: AOJu0Yz3b4Vn+Sm0LBNaHo4T1T8niYz1L87rPLoVUSNFtw9i/m2Uk6x/ UlVf2Le+vhsBXxrY02YmvshuWXhado//aDXucgBuAIi7kDMSUcjtZUVHd9qIx/0= X-Gm-Gg: ASbGnctGrA2vnMJ+ONbQy+ElVoy7Aw6p+C0M4PiEjBYb2EcguPJNsU/xrqu3Y/Pnf17 C6jtaUUW6eYpFQ7K0fHFT6dFskRmg8xEjhB8tRb/gFZJFUjYIu77N6ueCecmhAhlEiLpqz/ui/o UpuGWtTNthcBs7q5OlcfnmuQUJrnbNw9usvVzzENkKUTT2/gv5DXEhshhdoPXFv02RiK4v/xL/T AvxM8Cw3qqpDntervUTz52+iwb9q9n4e1goYRCz4jzPHttHAiUUBdhxKPhzP4ehoFAlHB/l5k1k FjPJ X-Google-Smtp-Source: AGHT+IETiRXoQSjhqFAYlk6Wqt2G/2hm//dP61dZAbkxSrUOgOP4ozfPdYXiY6KLOb15FJHuSlggfg== X-Received: by 2002:a17:907:3e21:b0:ab6:5558:4922 with SMTP id a640c23a62f3a-ab655585167mr197757766b.41.1737539352139; Wed, 22 Jan 2025 01:49:12 -0800 (PST) Date: Wed, 22 Jan 2025 10:49:04 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Stefano Stabellini , Andrew Cooper , Alejandro Vallejo , "xen-devel@lists.xenproject.org" , Julien Grall , Wei Liu , sergiy_kibrik@epam.com Subject: Re: [PATCH v2 1/4] x86: provide an inverted Kconfig control for shim-exclusive mode Message-ID: References: <6285f86d-f2d2-4040-999d-01aed3e72a36@suse.com> <40c9d806-000d-43e7-a804-ad4e84209b2f@suse.com> <41859184-bd9c-420f-96c1-65abe379b81e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jan 22, 2025 at 09:43:53AM +0100, Jan Beulich wrote: > On 21.01.2025 19:02, Roger Pau Monné wrote: > > On Tue, Jan 21, 2025 at 11:35:42AM +0100, Jan Beulich wrote: > >> On 21.01.2025 09:52, Roger Pau Monné wrote: > >>> On Tue, Jan 21, 2025 at 09:13:38AM +0100, Jan Beulich wrote: > >>>> On 21.01.2025 00:27, Stefano Stabellini wrote: > >>>>> If I understood it right, I like Andrew's suggestion. He is suggesting > >>>>> to do the following: > >>>>> > >>>>> - turning PV_SHIM_EXCLUSIVE into something that does nothing > >>>> > >>>> FTAOD - you mean Kconfig-wise? Andrew clearly didn't say "nothing", but > >>>> "nothing other than making the boolean be a compile time constant". > >>> > >>> Won't making the boolean a compile time constant would also result in > >>> DCO kicking in and removing a fair amount of code? So even if you > >>> have enabled everything in Kconfig, the resulting hypervisor would > >>> only be suitable to be used as a shim? > >> > >> Of course. > > > > Then what's the point of this approach? Options will be enabled in > > Kconfig, but the resulting hypervisor build when using allyesconfig > > would have a lot of them short-circuited, making it even worse than > > currently? As options will get effectively build-time disabled due > > to DCO while enabled in Kconfig. > > Well, I have to direct this question to Andrew. It is specifically > what I'm trying to address with UNCONSTRAINED. > > > Overall I think PV_SHIM_EXCLUSIVE should be excluded from > > allyesconfig, even with Andrew's proposed change. Otherwise the > > purpose of allyesconfig is defeated if enabling PV_SHIM_EXCLUSIVE > > makes the resulting hypervisor build PV shim only. IIRC we can > > provide a default alllyes.config with CONFIG_PV_SHIM_EXCLUSIVE=n. > > Hmm, I wasn't aware of the option of using allyes.config. That might be > the route to go, albeit it looks like people using the allyesconfig > target then need to remember to set KCONFIG_ALLCONFIG in the environment > (to or 1), or to explicitly specify a file name that way. (This > of course ought to be easy enough to arrange for in our automation.) My knowledge of Kconfig is very limited, but isn't there a default path for such file to be picked up by Kconfig? I see we already have a xen/tools/kconfig/allrandom.config, I was expecting it would be a matter of dropping an allyes.config in that directory, but I haven't tried. Thanks, Roger.