From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Jordan Justen <jljusten@debian.org>
Subject: Re: [PATCH i-g-t] tools: rename power into igt_power
Date: Wed, 22 Jan 2025 14:49:47 +0200 [thread overview]
Message-ID: <Z5Dpax83XCl7rkQN@intel.com> (raw)
In-Reply-To: <20250121154919.181947-1-kamil.konieczny@linux.intel.com>
On Tue, Jan 21, 2025 at 04:49:19PM +0100, Kamil Konieczny wrote:
> Some distros installs igt tools in /usr/bin and as long as
> a name of a tool has a prefix of igt_ or intel_ it will not
> cause a problem. However name like 'power' is a little too
> generic, so change it into igt_power.
>
> Fixes: a886e0ad9783 ("tools/power: Introduce a small power/energy measurement tool")
> Reported-by: Jordan Justen <jljusten@debian.org>
> Closes: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/168
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tools/{power.c => igt_power.c} | 0
> tools/meson.build | 2 +-
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename tools/{power.c => igt_power.c} (100%)
>
> diff --git a/tools/power.c b/tools/igt_power.c
> similarity index 100%
> rename from tools/power.c
> rename to tools/igt_power.c
> diff --git a/tools/meson.build b/tools/meson.build
> index 511aec69e..f091af380 100644
> --- a/tools/meson.build
> +++ b/tools/meson.build
> @@ -12,6 +12,7 @@ foreach prog : tools_progs_noisnt
> endforeach
>
> tools_progs = [
> + 'igt_power',
> 'igt_stats',
> 'intel_audio_dump',
> 'intel_backlight',
> @@ -44,7 +45,6 @@ tools_progs = [
> 'dpcd_reg',
> 'lsfacts',
> 'lsgpu',
> - 'power',
> ]
> tool_deps = igt_deps
> tool_deps += zlib
> --
> 2.48.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2025-01-22 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 15:49 [PATCH i-g-t] tools: rename power into igt_power Kamil Konieczny
2025-01-22 1:18 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-01-22 1:20 ` ✓ i915.CI.BAT: " Patchwork
2025-01-22 9:30 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-22 13:05 ` Kamil Konieczny
2025-01-22 10:33 ` [PATCH i-g-t] " Dandamudi, Priyanka
2025-01-22 12:49 ` Ville Syrjälä [this message]
2025-01-23 10:17 ` ✗ i915.CI.Full: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5Dpax83XCl7rkQN@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jljusten@debian.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.