From: Peter Xu <peterx@redhat.com>
To: "“William Roche" <william.roche@oracle.com>
Cc: david@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
philmd@linaro.org
Subject: Re: [PATCH v3 1/1] system/physmem: take into account fd_offset for file fallocate
Date: Wed, 22 Jan 2025 15:11:09 -0500 [thread overview]
Message-ID: <Z5FQ3Up1UeBL4dlx@x1n> (raw)
In-Reply-To: <20250122194053.3103617-2-william.roche@oracle.com>
On Wed, Jan 22, 2025 at 07:40:53PM +0000, “William Roche wrote:
> From: William Roche <william.roche@oracle.com>
>
> Punching a hole in a file with fallocate needs to take into account the
> fd_offset value for a correct file location.
> But guest_memfd internal use doesn't currently consider fd_offset.
>
> Fixes: 4b870dc4d0c0 ("hostmem-file: add offset option")
>
> Signed-off-by: William Roche <william.roche@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2025-01-22 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 19:40 [PATCH v3 0/1] fallocate missing fd_offset “William Roche
2025-01-22 19:40 ` [PATCH v3 1/1] system/physmem: take into account fd_offset for file fallocate “William Roche
2025-01-22 20:11 ` Peter Xu [this message]
2025-01-22 21:41 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5FQ3Up1UeBL4dlx@x1n \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=william.roche@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.