Re: [PATCH v5] hw/i386/cpu: remove default_cpu_version and simplify

[Zhao Liu <zhao1.liu@intel.com>]

>  hw/i386/microvm.c     |  3 +-
>  hw/i386/pc.c          | 14 +++++++++
>  hw/i386/pc_piix.c     |  6 ++--
>  hw/i386/pc_q35.c      |  6 ++--
>  hw/i386/x86-common.c  |  4 +--
>  include/hw/i386/pc.h  |  7 +++--
>  include/hw/i386/x86.h |  2 +-
>  target/i386/cpu.c     | 69 ++++++++++++++++++++++---------------------
>  target/i386/cpu.h     | 21 +++----------
>  9 files changed, 67 insertions(+), 65 deletions(-)
> 
> changelog:
> v2: explain in commit log why use of CPU_VERSION_LATEST for machines
> is problematic.
> v3: fix a bug that broke the pipeline
> https://gitlab.com/mstredhat/qemu/-/pipelines/1626171267
> when cpu versions are explicitly specified in the command line,
> respect that and do not enforce legacy (unversioned) cpu logic.
> The pipeline is green now with the fix:
> https://gitlab.com/anisinha/qemu/-/pipelines/1626783632
> v4: made changes as per Zhao's suggestions.
> Pipeline passes https://gitlab.com/anisinha/qemu/-/pipelines/1635829877
> v5: adjustment of pc_init_cpus() declaration as per Zhao's suggestion. This
> simplifies things and also passes compilation.
> CI still passes https://gitlab.com/anisinha/qemu/-/pipelines/1637657451

v5 is fine for me, so

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Let's see if anyone else has comments.