From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: Re: [PATCH for-4.20 v3 2/4] x86/HVM: correct read/write split at page boundaries
Date: Thu, 23 Jan 2025 13:43:58 +0100 [thread overview]
Message-ID: <Z5I5jsqp7_MG_6dJ@macbook.local> (raw)
In-Reply-To: <5bd5cad3-698e-420b-aa97-e84763df0420@suse.com>
On Thu, Jan 23, 2025 at 11:31:19AM +0100, Jan Beulich wrote:
> The MMIO cache is intended to have one entry used per independent memory
> access that an insn does. This, in particular, is supposed to be
> ignoring any page boundary crossing. Therefore when looking up a cache
> entry, the access'es starting (linear) address is relevant, not the one
> possibly advanced past a page boundary.
>
> In order for the same offset-into-buffer variable to be usable in
> hvmemul_phys_mmio_access() for both the caller's buffer and the cache
> entry's it is further necessary to have the un-adjusted caller buffer
> passed into there.
>
> Fixes: 2d527ba310dc ("x86/hvm: split all linear reads and writes at page boundary")
> Reported-by: Manuel Andreas <manuel.andreas@tum.de>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
next prev parent reply other threads:[~2025-01-23 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 10:29 [PATCH partly-for-4.20 v3 0/4] x86/HVM: emulation (MMIO) improvements Jan Beulich
2025-01-23 10:30 ` [PATCH for-4.20 v3 1/4] x86/HVM: allocate emulation cache entries dynamically Jan Beulich
2025-01-23 10:31 ` [PATCH for-4.20 v3 2/4] x86/HVM: correct read/write split at page boundaries Jan Beulich
2025-01-23 12:43 ` Roger Pau Monné [this message]
2025-01-23 10:31 ` [PATCH v3 3/4] x86/HVM: slightly improve CMPXCHG16B emulation Jan Beulich
2025-01-23 10:32 ` [PATCH v3 4/4] x86/HVM: drop redundant access splitting Jan Beulich
2025-01-23 15:09 ` [PATCH partly-for-4.20 v3 0/4] x86/HVM: emulation (MMIO) improvements Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5I5jsqp7_MG_6dJ@macbook.local \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.