From: Patrick Steinhardt <ps@pks.im>
To: Meet Soni <meetsoni3017@gmail.com>
Cc: git@vger.kernel.org, shubham.kanodia10@gmail.com,
Elijah Newren <newren@gmail.com>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [RFC PATCH 3/3] refspec: relocate apply_refspecs and related funtions
Date: Fri, 24 Jan 2025 09:01:50 +0100 [thread overview]
Message-ID: <Z5NI7vQ66aSCgjjg@pks.im> (raw)
In-Reply-To: <20250122075154.5697-4-meetsoni3017@gmail.com>
On Wed, Jan 22, 2025 at 01:21:54PM +0530, Meet Soni wrote:
> diff --git a/refspec.h b/refspec.h
> index d3c97bfdc5..294068d226 100644
> --- a/refspec.h
> +++ b/refspec.h
> @@ -86,4 +86,12 @@ void query_refspecs_multiple(struct refspec *rs,
> struct refspec_item *query,
> struct string_list *results);
>
> +/*
> + * Remove all entries in the input list which match any negative refspec in
> + * the refspec list.
> + */
> +struct ref *apply_negative_refspecs(struct ref *ref_map, struct refspec *rs);
> +
> +char *apply_refspecs(struct refspec *rs, const char *name);
> +
> #endif /* REFSPEC_H */
Same comment here regarding the documentation of `apply_refspecs()`.
Patrick
next prev parent reply other threads:[~2025-01-24 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 7:51 [RFC PATCH 0/3] refspec: centralize refspec-related logic Meet Soni
2025-01-22 7:51 ` [RFC PATCH 1/3] refspec: relocate omit_name_by_refspec and related functions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-22 7:51 ` [RFC PATCH 2/3] refspec: relocate query " Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt
2025-01-22 7:51 ` [RFC PATCH 3/3] refspec: relocate apply_refspecs and related funtions Meet Soni
2025-01-24 8:01 ` Patrick Steinhardt [this message]
2025-01-24 8:01 ` [RFC PATCH 0/3] refspec: centralize refspec-related logic Patrick Steinhardt
2025-01-24 17:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5NI7vQ66aSCgjjg@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=meetsoni3017@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=shubham.kanodia10@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.