From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Yuntao Liu <liuyuntao12@huawei.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ruanjinjie@huawei.com,
kees@kernel.org, masahiroy@kernel.org
Subject: Re: [PATCH -next] arm32/boot/compressed: Force hidden visibility for all symbol references
Date: Fri, 24 Jan 2025 15:32:26 +0000 [thread overview]
Message-ID: <Z5OyivU-74fr4Vuz@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAMj1kXH5agoCW0gONDZAodHQKANgrix=pE4e5YuHKgR=GwTRwA@mail.gmail.com>
On Fri, Jan 24, 2025 at 03:00:10PM +0100, Ard Biesheuvel wrote:
> On Fri, 24 Jan 2025 at 09:31, Yuntao Liu <liuyuntao12@huawei.com> wrote:
> >
> > Eliminate all GOT entries in the decompressor binary, by forcing hidden
> > visibility for all symbol references, which informs the compiler that
> > such references will be resolved at link time without the need for
> > allocating GOT entries.
> >
> > Include linux/hidden.h in Makefile, like x86, for the
> > hidden visibility attribute.
> >
> > Signed-off-by: Yuntao Liu <liuyuntao12@huawei.com>
>
> Doesn't this break appended DTB?
Yes. It also breaks ZBOOT_ROM=y as well.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-01-24 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 8:20 [PATCH -next] arm32/boot/compressed: Force hidden visibility for all symbol references Yuntao Liu
2025-01-24 14:00 ` Ard Biesheuvel
2025-01-24 15:32 ` Russell King (Oracle) [this message]
2025-01-24 15:25 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5OyivU-74fr4Vuz@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=kees@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyuntao12@huawei.com \
--cc=masahiroy@kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.